]> git.koha-community.org Git - koha.git/commit
Bug 14693: Contract.t should generate dates based on current date
authorTomas Cohen Arazi <tomascohen@unc.edu.ar>
Wed, 19 Aug 2015 14:01:32 +0000 (11:01 -0300)
committerTomas Cohen Arazi <tomascohen@unc.edu.ar>
Fri, 21 Aug 2015 13:43:38 +0000 (10:43 -0300)
commite2ad507500bf36b7c8ea1d16f31e8155940e1909
tree185b7850cc503af8467ec12997191ba319c257bf
parenta6539ea73d87fbfcd0343ec17e705e198ac24b93
Bug 14693: Contract.t should generate dates based on current date

The current test for still-active contracts fails because it was written
with fixed dates, which already passed :-D

This patch calculates the current date, and uses it to generate a future
one, so the tests serve their purpose no matter what the current date is.

To test:
- Run:
  $ prove t/db_dependent/Contract.t
=> FAIL: activeonly compares contractenddate with now(), and fails
         because a fixed 2015-07-31 is writteng on the test data
- Apply the patch
- Run:
  $ prove t/db_dependent/Contract.t
=> SUCCESS: the sample data has been calculated using the current date
            and the tests pass.
- Sign off :-D

Edit: added missing use DateTime::Duration,

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
t/db_dependent/Contract.t