Bug 2553: Fixes the alphabetization of the drop-down lists for the Most-Circulated items report.
This patch alphabetizes the descriptions that appear in the Library, Item type, and patron category drop-down lists of the Most-Circulated Items report form.
Bug 2553: Fixes drop-down alphabetization in acquisitions - New order and Receive order.
Fixes alphabetization of library dropdown in New Order, and the shelf location, item type, and collection code in the Receive Items pages. This patch takes care of Joann's original purpose of creating the bug enhancement.
Bug 3408: Tag cloud says login when logged in - fix.
Changed the logic in the html form to have the login prompt only appear if a user is not logged in. Separated the hidemylist functionality from the "show tags from other users" option. Created a link for "hide my tags" or "show my tags" depending on context.
The user can now choose how many tags of other users to show, and can also choose whether to show their own tags or not.
Joe Atzberger [Mon, 20 Jul 2009 20:37:24 +0000 (15:37 -0500)]
Cannot use the same TMPL_VAR to select ALL options.
Only one select can be selected in this case. If preselection of search type is
desired, I recommend a clean implementation w/ jquery instead of adding a conditional
for each select. Please note, that is the only good way to get multiple preselections,
since the same .inc file will be used in each case. So a single variable like
<TMPL_IF NAME="index_bc_selected">
cannot be used, since it would set for ALL (3) advanced search dropdowns.
Joe Atzberger [Mon, 20 Jul 2009 22:47:42 +0000 (17:47 -0500)]
Remove bogus "selected" logic from OPAC adv. search.
The only reason the TMPL_VAR works where it does is because it is part
of the TMPL_LOOP. It doesn't mean anything outside the loops, since
*everything* would be selected with the same variable, indiscriminantly.
Joe Atzberger [Fri, 17 Jul 2009 14:56:31 +0000 (09:56 -0500)]
Add crontab instructrions.
Too many people have been confused about crontab dependent functions
"not working" automatically on their installations. This is probably
because there was no explicit step telling them to schedule the jobs.
The maintainers of the other INSTALL.* docs would be well advised
to insert similar lines in their docs, after confirming proper operation,
since cron/crontab are very system dependent.
(bug #3393) take care of default rules in overdues
This fix the overdues notices script, that doesn't take care of default rules.
Now if there is no specific rules for a branchcode, the script use the default rule if it exists.
The hash keys were made using a base and $item->{date_due}, but this key doesn't exists, so the possibility to have duplicate keys exists, and sometimes the others items were not shown. This patch fix this bug.
Garry Collum [Sat, 27 Jun 2009 17:48:18 +0000 (13:48 -0400)]
Bug 3317: Adds author and added-author to email sent from basket (Cart).
Adds the author and added author fields to the email that is sent from the shopping cart. This makes the data sent via email consistent with the data that is viewed in the basket.
There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.
Joe Atzberger [Tue, 30 Jun 2009 14:14:50 +0000 (09:14 -0500)]
LDAP overhaul
Allow replicate and update to be zero.
Break out logic into separate subs.
Do only one bind attempt depending on setting, instead of
necessarily failing first before trying auth_by_bind.
POD added for active directory and to document permutations of
behavior given different conditions. Fixed mistaken debug lines
that called "print STDERR printf ...", i.e. printed the line to output
and "1" to the error log. Added principal_name feature for generating
bind user from Koha userid.
For UNIMARC installations, this patch only works after
updating the "NoZebraIndexes" system preference to
UNIMARC indexes (by default, NoZebraIndexes is being
wrongly set to MARC21 values in UNIMARC installations).
That has also been reported as a Bug, by me (see Bug 2178):
Bug 2178 - "NoZebraIndexes" system preference is being set
to MARC21 values in UNIMARC installations
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2178
Frédéric Demians [Sun, 14 Jun 2009 05:17:40 +0000 (07:17 +0200)]
Bug 3301 - Speed up rebuild_zebra script
With this patch, rebuild_zebra can re-index a whole Koha DB
quickly:
rebuild_zebra -r -b -nosanitize
Biblio (authority) records are dump directly in a file
from marcxml field without beeing transformed into
MARC::Record object and corrected.
DOCUMENTATION:
rebuild_zebra.pl new paramater:
-nosanitize export biblio/authority records directly from DB marcxml
field without sanitizing records. It speed up
dump process but could fail if DB contains badly
encoded records. Works now only with -x and -b
Joe Atzberger [Sat, 20 Jun 2009 00:32:42 +0000 (19:32 -0500)]
checkoverdues should not require $dbh
Passing $dbh around is an ancient style that doesn't know
to use C4::Context. C4::Context->dbh is efficient, especially
for modules that already use Context, including almost all C4.
I also internalized $today into the SQL using NOW() in the query
and removed sth->finish. Even though I dislike the return style
that gives the count, then the array, I left it becuase I don't
have time to fix/test all the callers. However, I did convert
it so it doesn't require a $count variable and its own loop.
Joe Atzberger [Sat, 20 Jun 2009 00:32:44 +0000 (19:32 -0500)]
Return amount for CREDITS, POD rework.
The main change here is to get an {amount} field for CREDITS,
not just CHARGES. I also use a fallback to default value (5)
in case noissuescharge has been deleted or set to 0.
POD is reworked to keep the salient chunks
about patronflags in the correct section and format them for
easier reference. Deprecated display layer code.
Joe Atzberger [Sat, 20 Jun 2009 00:32:45 +0000 (19:32 -0500)]
Cleanup Members.pm - minor
MoveMemberToDeleted is problematic. It has a bad name, since it
only copies, not moves. Also the POD for it referenced a totally
different function name and was largely useless. Sanity checks inserted.
Jane Wagner [Fri, 19 Jun 2009 13:10:20 +0000 (09:10 -0400)]
Bug # 2368 Change holds to pull default date range
Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today. Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.
Joe Atzberger [Mon, 22 Jun 2009 19:40:56 +0000 (14:40 -0500)]
Bug 3350 - fail on queued emails w/ no address
If a patron has no email address, we need to avoid stockpiling all
their messages indefinitely. Otherwise they get mailbombed when
their email IS added.
Note that overdues should not be affected, since the overdues job
checks whether the patron email exists before sending the message
(falling back to the admin). The other messaging features are the
targets affected by this patch.
Ryan Higgins [Mon, 15 Jun 2009 22:20:29 +0000 (17:20 -0500)]
Add MARC21 Fast-add Framework.
Development is in progress for brief records
in Koha; until that's done, this framework can
be used to add a minimal record.
Created by debra.denault@liblime.com
Joe Atzberger [Fri, 12 Jun 2009 14:25:47 +0000 (09:25 -0500)]
Cleanup - admin scripts
Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish. Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).
Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.
Joe Atzberger [Wed, 10 Jun 2009 19:04:50 +0000 (14:04 -0500)]
Cleanup authtypes and currency .pl and .tmpl
Removed unused javascript. Enabled warnings. Use common $dbh.
Removed sth->finish calls. Removed toggle code. Added row highlight where
none had been implemented. Added some HTML escaping in TMPL.
Garry Collum [Thu, 11 Jun 2009 00:47:31 +0000 (20:47 -0400)]
Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Removed toggle variable from roadtype.pl and roadtype.tmpl. Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.
Galen Charlton [Tue, 9 Jun 2009 14:26:11 +0000 (09:26 -0500)]
removing disused script
serials/subscription-copy.pl had been removed
in commit 8c78ff5aa5d52e3b16ea4c45cc38dc6999100ac3 but
for some reason had been accidentally restored in
a subsequent commit.
Galen Charlton [Mon, 8 Jun 2009 20:11:42 +0000 (15:11 -0500)]
bug 3314: remove disused scripts and API functions
The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table. This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:
Joe Atzberger [Thu, 4 Jun 2009 17:43:53 +0000 (12:43 -0500)]
Standalone branch selection
selectbranchprinter now posts to itself to set the branch. That also means that
other pages can set the branch by linking to selectbranchprinter like:
/cgi-bin/koha/circ/selectbranchprinter.pl?branch=MAIN
We use HTTP_REFERER to allow the user to continue back to wherever they linked from,
defaulting to circulation.pl (the former POST target).
Note that all "branchprinter" functions are basically useless as the data is not
properly handled in the session storage. Chris C. expects this to be addressed
with later patches for HLT. There appear to be no 3.0 users of this intended
functionality yet.
Includes squashed patch to fix tmpl and to automatically redirect if there are no
POST params to be recycled.
Joe Atzberger [Fri, 29 May 2009 21:09:34 +0000 (16:09 -0500)]
Cleanup selectbranchprinter.pl and .tmpl
Use GetBranchesLoop and warnings. Remove unused code. Moved the Get's to after auth.
I begin to show how this script will use referer to redirect back to the sending
page upon successful change of branch or printer (see hidden div and recycle_loop).
Indicator for singleBranchMode added.
Also added another helper function for GetBranchesLoop, namely mybranch. This
encapsulates the logic for finding an intelligent default selection, which is
almost always desirable.
This does not resolve bug 2426, but is work in that direction.
Joe Atzberger [Fri, 5 Jun 2009 17:18:50 +0000 (12:18 -0500)]
Cleanup cities.pl and .tmpl - major
80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings. Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code. Etc.
TODO: Stop redirecting to the same page. Instead get the correct data and show it
on THIS pass.
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.
Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery. Performance improved.
Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.
Owen Leonard [Tue, 7 Apr 2009 19:48:16 +0000 (14:48 -0500)]
More fixes for Bug 3044
Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.
Owen Leonard [Sat, 4 Apr 2009 18:53:48 +0000 (13:53 -0500)]
New styles for bulk hold and bulk tag inputs on search results page.
This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.
* On Amazon book cover, 'search inside' text is not displayed
anymore because it's not translatable.
* Link the image to local Amazon web site 'search inside' service.
Based on AmazonLocale syspref.
Joe Atzberger [Fri, 13 Mar 2009 14:57:14 +0000 (09:57 -0500)]
DDCN callnumber splitting with test.
Similar to previous patch for LCCN splitting, this patch incorporates
changes to split_ddcn and supplies a test file for verifying proper
operation. Note that the only previously documented example for intended
operation is included as one of the tests.
This regexps are created to be rather forgiving. For example, the function
will not choke if two spaces were included where the "spec" (such as it is)
expects one. Obviously this is because for CN splitting purposes, it doesn't
matter, we're not going to ever split in the middle of whitespace.
projects / koha.git / log