root [Wed, 17 Feb 2010 18:24:46 +0000 (13:24 -0500)]
Bugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and returns.tmpl/pl and added a single syspref (set to off) along with very compressed OGG files for sound which are on the open source "artistic" licence.
Works for HTML5 because it loads smoothly and no plugins required but *at
this time* this update will only work with staff clients which are Firefox
version >=3.5 (std for Koha) but other browsers will soon be adding support.
Additional sounds are included for people to modify and play with, but this
is such a simple upgrade I doubt at this time Koha needs another complex
selector so users can add their own sounds. It could be a nice enhancement
later, of course.
Suggest we stick with HTML5 <audio tag because it is a standard and no
plug-ins.
This simple update has been running live for SMFPL.org for almost 2 weeks
Adds the ability to customize CSV exports through the use of a YAML file.
The following customizations are available :
- Preprocessing
- Postprocessing
- Field-by-field processing
The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b941f6f6094f705a296f7b68e64d148df)
Galen Charlton [Wed, 17 Feb 2010 11:39:22 +0000 (06:39 -0500)]
set Locale::Currency::Format dep test as DBrev 119
Also fixed bug that prevented updatedatabase.pl
from compiling if Locale::Currency::Format wasn't
already installed. To test to see if module is present,
do
Bugfix: [1/3] overdue_notices.pl does not process all advertised fields
Note: overdue_notices.pl really needs to be completely re-written.
The script does not process all fields advertised in tools/letter.pl
This patch adds code to process all fields advertised as well as any
from the items table.
It also adds two additional tags for use in the letter templates:
<item></item> which should enclose all fields from the biblio, biblioitems,
and items tables.
<fine></fine> which should be enclosed by the item tag and should
enclose a currency identifier per ISO 4217. If this tag is present with
a proper identifier, the fine for that item will be displayed in the
proper currency format. Note: ISO 4217 changes from time to time therefore
all currencies may not be supported. If you find one that is not
supported, please file a bug with the Locale::Currency::Format author
Tan D Nguyen <tnguyen at cpan doe org>.
An example of the implimentation of these two tags in a notice template
might be like:
The following item(s) is/are currently overdue:
<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item>
Which, assuming two items were overdue, would result in a notice like:
The following item(s) is/are currently overdue:
"A Short History of Western Civilization" by Harrison, John B, 909.09821 H2451, Barcode: 08030003 Fine: £3.50
"History of Western Civilization" by Hayes, Carlton Joseph Huntley, 909.09821 H3261 v.1, Barcode: 08030004 Fine: £3.50
Garry Collum [Mon, 15 Feb 2010 15:43:23 +0000 (10:43 -0500)]
Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.
Duplicates the code for searching by reviewer in the form that is used in searching via a link.
It looks like it was the intention of the original writer to filter by borrower number or by name. Filtering by name was not implemented. Added a FIXME reference to indicate this.
Galen Charlton [Mon, 15 Feb 2010 02:10:25 +0000 (21:10 -0500)]
bug 2885: attempting to add library with existing code now gives error message
If one attempts to add a new library with a code already in use,
an error message is shown. The main library data input by the user
is preserved, allowing the user to try a new code.
This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.
Colin Campbell [Fri, 12 Feb 2010 12:38:46 +0000 (12:38 +0000)]
Change default AUTH_INDEX_MODE to dom
[RM note: DOM is recommended for MARC21 authorities. As of
now, GRS-1 is the only mode supported for UNIMARC authorities.]
dom is the recommended authorities indexing mode in external docs
making it default accepts what appears to be the de facto preference
see Indexdata's documentation for more details on the options
Will Stokes [Sun, 14 Feb 2010 20:31:08 +0000 (09:31 +1300)]
Bug #2162: Step 2, add pagination. Splits results into blocks of 250 results and adds Previous and Next buttons. Achieved using forms, hidden search variables and submit buttons.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sun, 14 Feb 2010 23:05:45 +0000 (18:05 -0500)]
new test script to help debug template errors
From the POD:
NAME
show-template-structure.pl
DESCRIPTION
This script displays the structure of loops and conditional statements in
an HTML::Template::Pro template, and is an aid for debugging errors
reported by the xt/author/valid-templates.t test. It also identifies the
following errors:
* TMPL_IF/TMPL_UNLESS/TMPL_LOOP with no closing tag
* TMPL_ELSE with no initial TMPL_IF or TMPL_UNLESS
* extra closing tags
* HTML comment of the form <!-- TMPL_FOO ..., where TMPL_FOO is not a valid HTML::Template::Pro tag
Galen Charlton [Mon, 1 Feb 2010 16:19:22 +0000 (10:19 -0600)]
bug 4169: fix item batch modification for MARC21
The MARC21 framework uses $0 for the item withdrawn status. Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.
Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.
Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Liz Rea <lrea@nekls.org>
Frédéric Demians [Thu, 11 Feb 2010 21:28:41 +0000 (22:28 +0100)]
Bug 4154 - Follow-up
- Modify install-code.pl to install prefs with templates
- Update .po preferences file in order to get last 'en' preferences
For 3.4, I will do a script which will handle together the 3 .po file:
opac, intranet and preferences (and .tt files if necessary). Don't do it
now, since it will change files naming convention.
Bugfix: Make smart-rules.tmpl display zero values in fields.
Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.
This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.
USAGE
pref-trans init lang
Create a .po file in po directory, named lang-pref.po. This
file contains text to translate extracted from .pref files.
pref-trans update lang
Update a .po file in po directory, named lang-pref.po. This
file contains new text to translate extracted from .pref files.
Previous translated text are kept. There is a minor bug, which can’t
be fixed due to preferences data struture: preferences tab
subsection labels are lost when updating .po file.
pref-trans install lang
Use lang-pref.po file to translate the english version of
preferences files and copy those files in the appropriate
directory.
DESCRIPTION
Koha preferences are stored in a data structure found in
koha-tmpl/intranet-tmpl/en/module/admin/preferences/ files.
Depending of user language, other files are used. This script extract text
from ’en’ preference files, and put them in one .po file. This .po
file can be updated. When completed, a .po file can be applied to create
localized versions of preferences templates.
Owen Leonard [Wed, 10 Feb 2010 17:04:51 +0000 (12:04 -0500)]
Additional changes to fix Bug 3920, XSLTdetailDisplay syspref controls both OPAC and Intranet
This patch adds XSLTDetailsDisplay and XSLTResultsDisplay variables
for the staff client, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
variables to the OPAC. Note that the XSLTResultsDisplay doesn't actually
do anything because no one has added an XSLT version of search results
to the staff client.
Chris Cormack [Fri, 23 Oct 2009 22:30:37 +0000 (11:30 +1300)]
Fix for Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database
[Patch originally by Ricardo Dias Marques]
Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730
For 3.0.x head of the Git branch, the ISO 639-2 Language Code for
Portuguese in Koha database is wrong.
Specifically, in the table "language_rfc4646_to_iso639", when the
field "rfc4646_subtag" has the value "pt", the field "iso639_2_code"
should have the value of "por" and NOT the current one of "pol"
("pol" refers to "Polish" as correctly also appears for the code "pl",
in the row above the "pt" one).
In my test setups, this showed some serious sequences for people
that choose the Portuguese language in the Web Installer, namely:
- very weird look of Staff client with missing Header and Footer,
that renders the Staff client unusable
- Portuguese translation apparently not getting updated for the OPAC
(for people that do an Upgrade from a previous version)
This patch is for the 3.0.x branch (I tested it with that branch).
For the master branch, I don't have a database setup to create and
test a similar patch but Chris Cormack nicely volunteered to do that.
Thanks Chris!
Galen Charlton [Wed, 10 Feb 2010 12:11:17 +0000 (07:11 -0500)]
bug 4122: make WebBasedSelfCheck functional
The WebBasedSelfCheck preference is now functional - if a user
tries to use /cgi-bin/koha/sco/sco-main.pl if the preference
is not on, they get redirected to the OPAC home page.
Also, the patron image web service now returns HTTP 403 (forbidden) unless
both WebBasedSelfCheck and ShowPatronImageInWebBasedSelfCheck are on.
Galen Charlton [Wed, 10 Feb 2010 13:31:45 +0000 (08:31 -0500)]
bugs 3912, 4144: can now add contracts if dataformat is not metric
Fixed bug in date validation that prevented adding new contracts
if the dateformat syspref was set to something other than 'metric'.
In process, also removed three hand-written date validation routines
in favor of using JavaScript Date objects and the Date_from_syspref
function provided in calendar.inc.
This fixes bug 3912, and partially addresses bug 4144.
Galen Charlton [Wed, 10 Feb 2010 11:27:30 +0000 (06:27 -0500)]
removing test.pl
Following up on patch submitted by Colin Campbell, convinced
myself that this was a throwaway test script comitted in error.
Since it isn't of use otherwise, I've elected to remove it
instead of moving it to misc/split_test.pl as Colin proposes.
Zeno Tajoli [Sun, 17 May 2009 21:26:17 +0000 (23:26 +0200)]
Bug 3162 Fix only for [forward port of tempoary fix 3.0.x]
Note that this patch causes the authority subfield visibility
to match 3.0.x, but at a cost - only two options are available now,
hide all and show all, and much flexibility is lost. This will
need to be improved.
Galen Charlton [Tue, 9 Feb 2010 18:54:29 +0000 (13:54 -0500)]
bug 4145 - fix typo in sysprefs.sql
Fixed following error during new en installation:
ERROR 1064 (42000) at line 217: You have an error in your SQL syntax;
check the manual that corresponds to your MySQL server version for the right
syntax to use near ''XSLTDetailsDisplay','0','','Enable XSL stylesheet control
over details page dis' at line 1
Colin Campbell [Fri, 2 Oct 2009 11:22:47 +0000 (12:22 +0100)]
Bug 2505 Enabled warnings in authorities/*
Fixed obvious warnings generators in scripts
with mismatched comparisons or undefined variables
removed temporary variable selected while ensuring the
comparison it represented was between two defined variables
Colin Campbell [Wed, 21 Oct 2009 08:54:18 +0000 (09:54 +0100)]
Bug 3723 Correct return of Institution in Patron Info Resp
While the comment correctly notes that the order of variable length
fields is not fixed some units expect mandatory fields to
follow the sequence in the protocol definition and fail
parsing otherwise. Moved institution id to its expected
place in the patron information response.
Indented the first half of the if (patron_valid) so its clearer
that two cases are handled here.
Colin Campbell [Wed, 4 Nov 2009 21:15:55 +0000 (21:15 +0000)]
(Bug 3767 - Return error if checkin passed an invalid item
If an invalid item barcode is passed to checkin
the sip2 connection dies. This is because although
no item object is created its mehods are called in Checkin
To maintain the connection properly catch the condition
and return the correct response to the unit
(should also fix Bug #3696 )
projects / koha.git / log