From 365121cae2d4df41333d4e2144acfe8c8a82b9a9 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 26 Jul 2023 12:25:11 +0000
Subject: [PATCH] Bug 34402: Sorting holds on patron account includes articles

This patch adds some configuration to the table of holds shown on the
checkout and patron detail pages so that sorting by title correctly
excludes articles.

To test, apply the patch and clear your browser cache.

- Check out to a patron who has multiple holds on titles which include
  leading articles like "a" "an" and "the."
- Click the holds tab and click the "title" column to sort by title.
  - The titles should be correctly sorted alphabetically while ignoring
    articles.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../intranet-tmpl/prog/en/includes/patron-detail-tabs.inc      | 2 +-
 koha-tmpl/intranet-tmpl/prog/js/holds.js                       | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
index 0d5c4c740a..fa6ff2f34f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
@@ -143,7 +143,7 @@
                             <thead>
                                 <tr>
                                     <th>Hold date</th>
-                                    <th>Title</th>
+                                    <th class="anti-the">Title</th>
                                     <th>Call number</th>
                                     <th>Item type</th>
                                     <th>Barcode</th>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
index 0b223bf302..01538ebc31 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
@@ -314,6 +314,9 @@ $(document).ready(function() {
                 "bPaginate": false,
                 "bProcessing": true,
                 "bServerSide": false,
+                "aoColumnDefs": [
+                    { "type": "anti-the", "targets": [ "anti-the" ] }
+                ],
                 "ajax": {
                     "url": '/cgi-bin/koha/svc/holds',
                     "data": function ( d ) {
-- 
2.39.5