From 71e3928b7bdd776c3d00e78a39bcc2aabef6524d Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 21 Dec 2017 10:49:41 -0300 Subject: [PATCH] Bug 19315: Prevent crash if no items and not library set for the subscription Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- serials/routing-preview.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/serials/routing-preview.pl b/serials/routing-preview.pl index 709d9a2ada..56b1a73b35 100755 --- a/serials/routing-preview.pl +++ b/serials/routing-preview.pl @@ -63,13 +63,14 @@ my $subs = GetSubscription($subscriptionid); my ($tmp ,@serials) = GetSerials($subscriptionid); my ($template, $loggedinuser, $cookie); +my $library; if($ok){ # get biblio information.... my $biblionumber = $subs->{'bibnum'}; my ($count2,@bibitems) = GetBiblioItemByBiblioNumber($biblionumber); my @itemresults = GetItemsInfo( $biblionumber ); my $branch = @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode}; - my $branchname = Koha::Libraries->find($branch)->branchname; + $library = Koha::Libraries->find($branch); if (C4::Context->preference('RoutingListAddReserves')){ # get existing reserves ..... @@ -108,7 +109,6 @@ if($ok){ flagsrequired => {serials => '*'}, debug => 1, }); - $template->param("libraryname"=>$branchname); } else { ($template, $loggedinuser, $cookie) = get_template_and_user({template_name => "serials/routing-preview.tt", @@ -120,6 +120,8 @@ if($ok){ }); } +$template->param( libraryname => $library->branchname ) if $library; + my $memberloop = []; for my $routing (@routinglist) { my $member = Koha::Patrons->find( $routing->{borrowernumber} )->unblessed; -- 2.39.5