From 816758d76f319e4dcf5b7a53e5a0f111f48dafe9 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 1 Aug 2019 14:57:29 +0000 Subject: [PATCH] Bug 23411: Do not fall back to 'email' for SMS messages To test: 1 - Have a patron wiht an sms number, but no email 2 - Enable sms by setting SMSDriver syspref to Email 3 - Set Notice triggers to send an overdue via sms and email 4 - Ensure the selected notice is defined only for 'email' 5 - Checkout an overdue to the patron above You can set a specify a due date in the past 6 - perl misc/cronjobs/overdue_notices.pl -t 7 - Check the patron notices tab, they have a print notice and an SMS notice pending 8 - The SMS notice used the 'email' template 9 - Apply patch 10 - sudo koha-mysql kohadev 11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above}; 12 - Run the cron again 13 - Patron should have a print notice queued, no sms 14 - Define an SMS notice 15 - delete the message queue 16 - Run again 17 - The patron should have a print and an SMS Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 64d8beafa8b5745c5ca2e63fddaf2177246ce937) Signed-off-by: Lucas Gass --- misc/cronjobs/overdue_notices.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 75fd593c77..a4348fed24 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -699,8 +699,8 @@ END_SQL 'count' => $itemcount, }, # If there is no template defined for the requested letter - # Fallback on email - message_transport_type => $letter_exists ? $effective_mtt : 'email', + # Fallback on the original type + message_transport_type => $letter_exists ? $effective_mtt : $mtt, } ); unless ($letter) { -- 2.39.5