From 8ea97143a53baf145fe2bb707760a4631a18096a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 10 Nov 2020 14:11:10 +0100 Subject: [PATCH] Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable $serialitem is not a Koha::Item there, we need to fetch the item before. Test plan: Turn makePreviousSerialAvailable on Create a subscription Receive an serial item, mark it "arrived" Without this patch Koha explodes with No property notforloan for Koha::Serial::Item at /usr/share/perl5/Exception/Class/Base.pm line 88 Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)', 'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line 273 With this patch applied the notforloan and itype values are correctly set for the new serial item. Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit dc465736cd14a860ffbda1571012fe94fb1e65fa) Signed-off-by: Lucas Gass --- serials/serials-edit.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl index afe9110b46..ad0deb50a4 100755 --- a/serials/serials-edit.pl +++ b/serials/serials-edit.pl @@ -267,7 +267,8 @@ if ( $op and $op eq 'serialchangestatus' ) { my $subscriptioninfos = GetSubscription($subscriptionids[$i]); # Changing the status to "available" and the itemtype according to the previousitemtype db field - $serialitem->set( + my $item = Koha::Items->find($itemnumber); + $item->set( { notforloan => 0, itype => $subscriptioninfos->{'previousitemtype'} -- 2.39.5