From c57fb17f076f67a6d3abb93a6dc415a24dad65ca Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 14 Jul 2015 18:40:47 +0200 Subject: [PATCH] Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too A closer look at this plugin revealed the same things as earlier: [1] Since the click redirects to leader, the launcher is not used. In this case no template file existed. [2] Leader_video does not use Focus while leader does. This patch removes 'all' traces of leader_video. It includes a tiny db revision for those brave people using it. The only behavior change for them is the focus change. Test plan: [1] Run the db revision. [2] Check if the leader plugin still works as expected. [3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :) Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- .../value_builder/marc21_leader_video.pl | 91 ------------------- .../data/mysql/atomicupdate/14201c_video.sql | 2 + 2 files changed, 2 insertions(+), 91 deletions(-) delete mode 100755 cataloguing/value_builder/marc21_leader_video.pl create mode 100644 installer/data/mysql/atomicupdate/14201c_video.sql diff --git a/cataloguing/value_builder/marc21_leader_video.pl b/cataloguing/value_builder/marc21_leader_video.pl deleted file mode 100755 index 9f318a09a2..0000000000 --- a/cataloguing/value_builder/marc21_leader_video.pl +++ /dev/null @@ -1,91 +0,0 @@ -#!/usr/bin/perl - -# Converted to new plugin style (Bug 13437) - -# Copyright 2000-2002 Katipo Communications -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# Koha is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Koha; if not, see . - -use Modern::Perl; - -use C4::Auth; -use CGI qw ( -utf8 ); -use C4::Context; - -use C4::Search; -use C4::Output; - -my $builder = sub { - my ( $params ) = @_; - my $function_name = $params->{id}; - my $res = " - -"; - - return $res; -}; - -my $launcher = sub { - my ( $params ) = @_; - my $input = $params->{cgi}; - my $index = $input->param('index'); - my $result = $input->param('result'); - - my $dbh = C4::Context->dbh; - - my ( $template, $loggedinuser, $cookie ) = get_template_and_user( - { template_name => "cataloguing/value_builder/marc21_leader.tt", - query => $input, - type => "intranet", - authnotrequired => 0, - flagsrequired => { editcatalogue => '*' }, - debug => 1, - } - ); - $result = " ngm 7a " unless $result; - my $f5 = substr( $result, 5, 1 ); - my $f6 = substr( $result, 6, 1 ); - my $f7 = substr( $result, 7, 1 ); - my $f8 = substr( $result, 8, 1 ); - my $f9 = substr( $result, 9, 1 ); - my $f17 = substr( $result, 17, 1 ); - my $f18 = substr( $result, 18, 1 ); - my $f19 = substr( $result, 19, 1 ); - - $template->param( - index => $index, - "f5$f5" => 1, - "f6$f6" => 1, - "f7$f7" => 1, - "f8$f8" => 1, - "f9$f9" => 1, - "f17$f17" => 1, - "f18$f18" => 1, - "f19$f19" => 1, - ); - output_html_with_http_headers $input, $cookie, $template->output; -}; - -return { builder => $builder, launcher => $launcher }; \ No newline at end of file diff --git a/installer/data/mysql/atomicupdate/14201c_video.sql b/installer/data/mysql/atomicupdate/14201c_video.sql new file mode 100644 index 0000000000..f3d1689aac --- /dev/null +++ b/installer/data/mysql/atomicupdate/14201c_video.sql @@ -0,0 +1,2 @@ +-- move marc21_leader_video to marc21_leader +update marc_subfield_structure set value_builder='marc21_leader.pl' where value_builder='marc21_leader_video.pl'; -- 2.39.5