]> git.koha-community.org Git - koha.git/commit
Bug 9486: t/Letters.t loads modules in wrong order
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Thu, 24 Jan 2013 18:58:07 +0000 (13:58 -0500)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Thu, 24 Jan 2013 19:44:59 +0000 (14:44 -0500)
commit2189b88bb1d2cfeb5cbe7cf3c08f61dc4e98a1c7
treea43b5925ae09f0a09235fc430565a4c9d7af6f79
parent350fcf23a5ce63a62bf45fd29a3fcd14a0c4cbcb
Bug 9486: t/Letters.t loads modules in wrong order

Because the unit test t/Letters.t loads C4::Letters before C4::Context,
and C4::Letters is not even vaguely thread-safe, the test tends to fail.
Usually. Moving the dbh mocking to before the use_ok('C4::Letters') test
fixes the problem.

To test:
1) Before applying patch, run `prove t/Letters.t` a few times. Note that
   it fails most of the time, if not all the time.
2) Apply patch.
3) Repeat step (1), noting that now it passes every time.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as advertised.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
t/Letters.t