]> git.koha-community.org Git - koha.git/commit
Bug 30987: Fix relationship fields for patron full and quick add forms
authorLucas Gass <lucas@bywatersolutions.com>
Mon, 26 Feb 2024 15:59:29 +0000 (15:59 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 18 Apr 2024 14:51:13 +0000 (16:51 +0200)
commitfccbd327d9f93925917e7a4f478ab72c1d1f2363
tree4d938a555e64cd893be5c22eb17057496b66c98c
parent82fe22ff26fdcc203d1a6f9c281bd56cfff08f70
Bug 30987: Fix relationship fields for patron full and quick add forms

To test:
1. APPLY PATACH and restart services.
2. Find the borrowerRelationship system preference. The description should no longer include the words "Leave empty to deactivate."
3. Populate the system preference with at least 1 choice.
4. Find a patron category with can_be_guarantee set to 'Yes'.
5. Quick add a patron of that type, making sure the relationship field shows in the Patron guarantor section. ( You have to +Add gaurantor before this field will show )
6. The values in the dropdown should refelct the borrowerRelationship values.
7. With BorrowerMandatoryField make relationship mandatory.
8. Try step 5 again, this time the Relationship field should be mandatory.
9. Remove the field from  BorrowerMandatoryField and add it to BorrowerUnwantedField.
10. Do step 5 again, the relationship field should not show on the quick add form.

Signed-off-by: Myka Kennedy Stephens <mkstephens@fosgail.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
members/memberentry.pl