Jane Wagner [Fri, 19 Jun 2009 13:10:20 +0000 (09:10 -0400)]
Bug # 2368 Change holds to pull default date range
Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today. Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.
Joe Atzberger [Mon, 22 Jun 2009 19:40:56 +0000 (14:40 -0500)]
Bug 3350 - fail on queued emails w/ no address
If a patron has no email address, we need to avoid stockpiling all
their messages indefinitely. Otherwise they get mailbombed when
their email IS added.
Note that overdues should not be affected, since the overdues job
checks whether the patron email exists before sending the message
(falling back to the admin). The other messaging features are the
targets affected by this patch.
Galen Charlton [Wed, 17 Jun 2009 13:00:57 +0000 (08:00 -0500)]
bug 2893: extend conditions handled by AllowNotForLoanOverride
Prior to this patch, turning AllowNotForLoanOverride on
allowed the circ operator to permit the loan of an
item who's individual not-for-loan flag was set, but did
not allow the loan of an item whose item type's not-for-loan
flag was set. This patch extends the definition of the
system preference so that both cases are covered.
Ryan Higgins [Mon, 15 Jun 2009 22:20:29 +0000 (17:20 -0500)]
Add MARC21 Fast-add Framework.
Development is in progress for brief records
in Koha; until that's done, this framework can
be used to add a minimal record.
Created by debra.denault@liblime.com
Jane Wagner [Tue, 16 Jun 2009 16:28:06 +0000 (12:28 -0400)]
Revision to my earlier patch for displaying the user name on checked-out items
My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.
Garry Collum [Sat, 13 Jun 2009 14:51:45 +0000 (10:51 -0400)]
Bug 3228: Fix for Type: label in XSLT displays.
Empty nodes must be generated in the XML for MARC21slim2OPACResults - typeOf008 and MARC21slim2OPACResults - materialTypeCode when the fields in the Marc record do not exist. This patch fixes the "Type: " label. More testing needs to be done to see if any other labels appear in the Opac if the data is not defined in the MARC record.
This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.
Joe Atzberger [Fri, 12 Jun 2009 22:33:02 +0000 (17:33 -0500)]
Cleanup stopwords.pl and .tmpl
Remove "toggle" code and useless javascript.
Rework "SimpleSearch" to use just one argument.
Remove unnecessary dependencies.
Remove incorrectly pasted comments.
Remove queries that didn't do anything.
Enable warnings. Use one $dbh. Remove $sth->finish calls.
Joe Atzberger [Fri, 12 Jun 2009 22:33:03 +0000 (17:33 -0500)]
Cleanup - moremember.pl and .tmpl
Removed last 3 EXPR statements. Removed toggle code.
Fixed jquery for warning on image deletion.
Fixed permission check for image upload to be granular.
Lots of formatting/whitespace cleanup.
Removed useless form and unused template vars.
Garry Collum [Thu, 11 Jun 2009 19:15:38 +0000 (15:15 -0400)]
Bug 2889: Removed toggle variable from auth_tag_structure.pl and auth_subfields_structure.pl
Removed toggle variable from auth_tag_structure.pl and .tmpl. Used template __odd__ in auth_tag_structure.tmpl.
Removed toggle variable from auth_subfields_structure.pl and .tmpl. Use __odd__. Removed a type in the highlight class definition. Fixed a minor xhtml error.
Joe Atzberger [Wed, 10 Jun 2009 21:53:27 +0000 (16:53 -0500)]
Cleanup classsources.pl and .tmpl
Relatively minor cleaning.
Remove unused javascript. Add row highlighting to both tables. Remove conditionals where the
behavior is the same for both possibilities.
Joe Atzberger [Fri, 12 Jun 2009 14:25:47 +0000 (09:25 -0500)]
Cleanup - admin scripts
Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish. Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).
Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.
Joe Atzberger [Wed, 10 Jun 2009 19:04:50 +0000 (14:04 -0500)]
Cleanup authtypes and currency .pl and .tmpl
Removed unused javascript. Enabled warnings. Use common $dbh.
Removed sth->finish calls. Removed toggle code. Added row highlight where
none had been implemented. Added some HTML escaping in TMPL.
Garry Collum [Thu, 11 Jun 2009 00:47:31 +0000 (20:47 -0400)]
Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Removed toggle variable from roadtype.pl and roadtype.tmpl. Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.
Galen Charlton [Tue, 9 Jun 2009 14:26:11 +0000 (09:26 -0500)]
removing disused script
serials/subscription-copy.pl had been removed
in commit 8c78ff5aa5d52e3b16ea4c45cc38dc6999100ac3 but
for some reason had been accidentally restored in
a subsequent commit.
Galen Charlton [Mon, 8 Jun 2009 20:11:42 +0000 (15:11 -0500)]
bug 3314: remove disused scripts and API functions
The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table. This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:
Removed a buggy conditional if that resulted in an incorrect item status
Previous conditional check with if ($restype) is not needed because a true
result for one item will result in subsqeuent items defaulting to this true
value.
Galen Charlton [Sat, 6 Jun 2009 21:45:54 +0000 (16:45 -0500)]
bug 2926: fix staging import hang
Fixes a hang of the staging import tool when it
attempts to process a MARC21 record that claims
that it's UTF-8 when it is not. The staging import
will now attempt to fix the character encoding of such
records.
Also added a FIXME to bulkmarcimport.pl, which because
of its use of MARC::Batch will skip over such records -
better than the original hang of the staging import, but
worse than the staging import's new ability to fix such
records.
replacing issues.itemnumber by statistics.itemnumber
since issues was not included in the query.
All statistics on circulation for item count were zeroed.
[RM note: specifically, this patch fixes the results
when you set the 'cell value' to 'count unique items']
savitra.sirohi [Thu, 4 Jun 2009 10:37:14 +0000 (16:07 +0530)]
Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages.
This is available only on the masthead search box in the OPAC.
User has to enter a word in english and press space or return to transliterate the word. The destination language can be selected from a drop down list. User can temporarily turn on/off the feature by using "ctrl +g".
A system preference - GoogleIndicTransliteration can be used to turn on this feature.
Joe Atzberger [Thu, 4 Jun 2009 17:43:53 +0000 (12:43 -0500)]
Standalone branch selection
selectbranchprinter now posts to itself to set the branch. That also means that
other pages can set the branch by linking to selectbranchprinter like:
/cgi-bin/koha/circ/selectbranchprinter.pl?branch=MAIN
We use HTTP_REFERER to allow the user to continue back to wherever they linked from,
defaulting to circulation.pl (the former POST target).
Note that all "branchprinter" functions are basically useless as the data is not
properly handled in the session storage. Chris C. expects this to be addressed
with later patches for HLT. There appear to be no 3.0 users of this intended
functionality yet.
Includes squashed patch to fix tmpl and to automatically redirect if there are no
POST params to be recycled.
Joe Atzberger [Fri, 29 May 2009 21:09:34 +0000 (16:09 -0500)]
Cleanup selectbranchprinter.pl and .tmpl
Use GetBranchesLoop and warnings. Remove unused code. Moved the Get's to after auth.
I begin to show how this script will use referer to redirect back to the sending
page upon successful change of branch or printer (see hidden div and recycle_loop).
Indicator for singleBranchMode added.
Also added another helper function for GetBranchesLoop, namely mybranch. This
encapsulates the logic for finding an intelligent default selection, which is
almost always desirable.
This does not resolve bug 2426, but is work in that direction.
Joe Atzberger [Fri, 5 Jun 2009 17:18:50 +0000 (12:18 -0500)]
Cleanup cities.pl and .tmpl - major
80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings. Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code. Etc.
TODO: Stop redirecting to the same page. Instead get the correct data and show it
on THIS pass.
projects / koha.git / log