From 87a2aa8a62cb1d3018329c0123ad6f8e908aa3b3 Mon Sep 17 00:00:00 2001 From: Laura Escamilla Date: Wed, 15 May 2024 15:34:22 +0000 Subject: [PATCH] Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin 1. Select/Create Library Branches: - Select or create two library branches: Library A and Library B. 2. Locate/Create Item: - Locate or create an item with the "Current library" and "Home library" set to Library A. 3. Place Hold: - Place a hold on the item for a patron whose pickup location is Library B. 4. Check-in at Library A - First Attempt: - Check in the item at Library A. - Verify that the 'Hold found' modal pops up. - Click on 'Confirm hold and transfer'. 5. Check-in at Library A - Second Attempt: - Check in the item at Library A again. - Verify that the 'Hold found' modal pops up. - Click on 'Ignore'. - Verify that the 'Please return this item to (Library B)' modal has popped up behind it. 6. Apply Patch and Restart: - Apply the patch to the system. - Restart all relevant services. 7. Repeat Check-in Process: - Repeat steps 4 and 5. - Verify that no matter how many times you check in the item and hit 'Ignore' or 'Confirm the hold', the second modal does not pop up. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 6c132ef2b8..875ac47c0d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -739,7 +739,7 @@ [% END # /IF waiting %] - [% IF transfer || needstransfer %] + [% IF (transfer || needstransfer) && !(reserved and !recalled and !waitingrecall) %] [% IF Koha.Preference('TransfersBlockCirc') %]