From c6f1f64cb71e9d8ec560a201a4a0bc16c1510f3f Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 15 Jun 2012 14:51:42 -0300 Subject: [PATCH] Bug 8251 - Patrons get incorrectly debarred Patrons get incorrectly debarred because of the use of Datetime->delta_days wich happens to always return a positive number. Also changed the use of Datetime->truncate function so it follows the docs, using 'day' instead of 'days' (which is used in DateTime::Duration). This patch has been tested against master. Signed-off-by: Julian Maurice Signed-off-by: Paul Poulain --- Koha/Calendar.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm index f63e7eb891..dc132cd2ac 100644 --- a/Koha/Calendar.pm +++ b/Koha/Calendar.pm @@ -173,9 +173,9 @@ sub days_between { my $dateend_temp = $end_dt->clone(); # start and end should not be closed days - my $duration = $dateend_temp->delta_days($datestart_temp); - $datestart_temp->truncate( to => 'days' ); - $dateend_temp->truncate( to => 'days' ); + $datestart_temp->truncate( to => 'day' ); + $dateend_temp->truncate( to => 'day' ); + my $duration = $dateend_temp - $datestart_temp; while ( DateTime->compare( $datestart_temp, $dateend_temp ) == -1 ) { $datestart_temp->add( days => 1 ); if ( $self->is_holiday($datestart_temp) ) { -- 2.39.5