From f9719f7bd8a7cc3f16eb5dffb3e43eaf9c254edd Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 22 Aug 2022 13:06:14 -0300 Subject: [PATCH] Bug 29955: Fix method import issues This patch fixes this: $ prove t/db_dependent/Utils/Datatables_Virtualshelves.t t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248. Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=32080 Signed-off-by: Blou Signed-off-by: Lucas Gass (cherry picked from commit 432fa9415defcde4d225ad06f1872bf2bfd7c276) Signed-off-by: Arthur Suzuki --- Koha/Virtualshelf.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Koha/Virtualshelf.pm b/Koha/Virtualshelf.pm index a7273a95d9..0fefc6ee2a 100644 --- a/Koha/Virtualshelf.pm +++ b/Koha/Virtualshelf.pm @@ -18,7 +18,7 @@ package Koha::Virtualshelf; use Modern::Perl; -use C4::Auth qw( haspermission ); +use C4::Auth; use Koha::Patrons; use Koha::Database; @@ -237,6 +237,11 @@ sub can_be_managed { my ( $self, $borrowernumber ) = @_; return 1 if $borrowernumber and $self->owner == $borrowernumber; + + my $patron = Koha::Patrons->find( $borrowernumber ) or return 0; + return 1 + if $self->is_public and C4::Auth::haspermission( $patron->userid, { lists => 'edit_public_lists' } ); + return 0; } -- 2.39.5