From 319603dd5e00dac62aebbfbd84a56134e24bc690 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 13 Nov 2020 16:33:40 +0000 Subject: [PATCH] Bug 26903: [20.05.x] Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Bug 26903: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry --- Koha/SearchEngine/Elasticsearch/Indexer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Koha/SearchEngine/Elasticsearch/Indexer.pm b/Koha/SearchEngine/Elasticsearch/Indexer.pm index 38946d2843..e5f6474fb3 100644 --- a/Koha/SearchEngine/Elasticsearch/Indexer.pm +++ b/Koha/SearchEngine/Elasticsearch/Indexer.pm @@ -101,7 +101,6 @@ sub update_index { my $documents = $self->marc_records_to_documents($records); my @body; - for (my $i = 0; $i < scalar @$biblionums; $i++) { my $id = $biblionums->[$i]; my $document = $documents->[$i]; @@ -302,7 +301,9 @@ sub index_records { $records = [$records] if ref $records ne 'ARRAY' && defined $records; if ( $op eq 'specialUpdate' ) { my $index_record_numbers; - unless ($records) { + if ($records){ + $index_record_numbers = $record_numbers; + } else { foreach my $record_number ( @$record_numbers ){ my $record = _get_record( $record_number, $server ); if( $record ){ -- 2.39.5