From cb6029fa179c61d52dea251f6fe5d24d0313df53 Mon Sep 17 00:00:00 2001 From: Kyle Hall Date: Tue, 1 Mar 2022 11:49:49 -0500 Subject: [PATCH] Bug 30207: Librarians with only "place_holds" permission can no longer update hold pickup locations Bug 29540 increased the flags required to for modreserve.pl, but in doing so created a situation where a library can select a different pickup location for a hold, but upon clicking the "Update hold(s)" button, will be logged out due to having insufficient permissions for modreserve.pl. Test Plan: 1) Create a librarian with "place_holds" permissions, but not "modify_holds_priority". 2) Place a hold for a patron 3) Attempt to change the pickup location from request.pl 4) Note you get logged out with a permissions error 5) Apply this patch 6) Restart all the things! 7) Attempt to change the pickup location from request.pl 8) This time it should succeed! Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Fridolin Somers (cherry picked from commit 3a13667ad32c56577db6a8e075a4cea5512eed8a) Signed-off-by: Arthur Suzuki --- reserve/modrequest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl index d95e82e815..76cb8a9d0d 100755 --- a/reserve/modrequest.pl +++ b/reserve/modrequest.pl @@ -38,7 +38,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( template_name => "about.tt", query => $query, type => "intranet", - flagsrequired => { reserveforothers => 1 }, + flagsrequired => { reserveforothers => [ 'place_holds', 'modify_holds_priority' ] }, } ); -- 2.39.5