]> git.koha-community.org Git - koha.git/commit
Bug 27117: Only place_holds permission is needed to adjust pickup locations
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 1 Dec 2020 10:44:04 +0000 (11:44 +0100)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 28 Dec 2020 15:25:04 +0000 (15:25 +0000)
commit0df90fcc5a4f56bb5e880cf3f85cc0e7a35ab598
tree7cbcb7fe544569c82c75ff3ffa2c67d45b70bc7d
parent9486558416f3a8016aa1d1171a72fcf2373aa093
Bug 27117: Only place_holds permission is needed to adjust pickup locations

The GET /pickup_locations route is requesting the whole reserveforothers
permission whereas only the subpermission place_holds is needed.

Test plan:
0. Don't apply this patch
1. Set the subpermission place_holds but modify_holds_priority
2. Edit a hold and click the pickup library dropdown list
3. You get a JS alert and log displays
  GET /api/v1/app.pl/api/v1/holds/5/pickup_locations
  403 Forbidden
4. Apply this patch
5. Reload the page, click the dropdown list, modify the pickup location
and save
=> Success!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 69c01ee0f2dccd04cfbe8201ba580a15727f5280)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 05ba6b702e1e267ec110c83f0b3e133a023d7948)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
api/v1/swagger/paths/holds.json
t/db_dependent/api/v1/holds.t