]> git.koha-community.org Git - koha.git/commit
Bug 18624: Run time errors when searching authorities with Elastic search 5.3
authorNick Clemens <nick@bywatersolutions.com>
Fri, 16 Jun 2017 13:53:39 +0000 (09:53 -0400)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 6 Sep 2017 13:22:02 +0000 (15:22 +0200)
commit1f83e41f2e9d92027401b6ffc8ebe052fe0beab3
tree6148ef6a9c94c8b97acfcca9319a66b2c85d2a48
parentefd3acb03e345a4e5c7f576038ed14961bbab3d6
Bug 18624: Run time errors when searching authorities with Elastic search 5.3

It seems we have a syntax mismatch - any vs all

all seems to the be list we expect so updating code that way

To test:
1 - Enabled Elasticsearch
2 - Index some authorities
3 - Perform a 'Search entire record' search
4 - Internal server error (
        Invalid marclist field provided: all at
        /usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
        line 433.
        )
5 - Run:
    $ sudo koha-shell kohadev
   k$ cd kohaclone
   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> FAIL: Tests fail because 'any is used'
6 - Apply patch
7 - Search should work
8 - Run:
   k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
=> SUCCESS: Tests pass!
9 Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edited the test plan so it mentions the new tests

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit cfb52579ec2f8859226e0e40f66d5a6d7a2ed73f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm