]> git.koha-community.org Git - koha.git/commit
Bug 20110: Adding same user multiple times to same budget
authorPasi Kallinen <pasi.kallinen@joensuu.fi>
Wed, 31 Jan 2018 09:11:56 +0000 (11:11 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 5 Feb 2018 12:47:33 +0000 (09:47 -0300)
commit3c2cd21cc35fdb5a048c042add0087ebedbca44e
treedc946abc35c82151867f0db41a44f45b9785a05d
parent127da0e35c5117e4c6ad7a208087cf191745b49b
Bug 20110: Adding same user multiple times to same budget

In javascript, using indexOf to test if a number exists in an array
of strings doesn't work, and makes it possible to add the same user
multiple times into the same budget fund.
Make borrowernumber into string and compare that instead.

Test plan:

1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund
2) Add a user to the fund
3) Try to add the same user again to the same fund. No error.
4) Apply patch
5) Do 1, 2, and 3 again. You should now get an error message
   saying the user is already in the list.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt