]> git.koha-community.org Git - koha.git/commit
Bug 26751: Fix fatal exception if only one repo defined
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 20 Oct 2020 17:40:50 +0000 (14:40 -0300)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 13 Nov 2020 18:16:20 +0000 (18:16 +0000)
commit710c9039ee6a1f465d1615f56ceafd3cb26fb184
tree25a48050b1b72508014527611c7495924860d2d9
parentacd96409ea869862506233cee3404e14254e5725
Bug 26751: Fix fatal exception if only one repo defined

This patch fixes this nasty problem with how XML is parsed: if more than
one entry is found, repo => [] is generated. If only one, repo => {}.

To test:
1. Have more than one entries in the plugins_repo entry:

<plugin_repos>
    <repo>
        <name>ByWater Solutions</name>
        <org_name>bywatersolutions</org_name>
        <service>github</service>
    </repo>
    <repo>
        <name>Theke Solutions</name>
        <org_name>thekesolutions</org_name>
        <service>github</service>
    </repo>
    <repo>
        <name>PTFS Europe</name>
        <org_name>ptfs-europe</org_name>
        <service>github</service>
    </repo>
 </plugin_repos>

2. Search for plugins
=> SUCCESS: Searching works!
3. Leave only one entry
4. Restart all to refresh things
5. Try searching for plugins
=> FAIL: Fatal error
6. Apply this patch
7. Repeat 5
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9e5ea4f5ab81cb500f112a5858130f82a6b4fd65)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
plugins/plugins-home.pl