]> git.koha-community.org Git - koha.git/commit
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers
authorKevin Carnes <kevin.carnes@ub.lu.se>
Fri, 18 Aug 2023 11:37:51 +0000 (13:37 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 29 Aug 2023 17:37:08 +0000 (14:37 -0300)
commite0007bf3623a6e58091eb233c95610761ac33a9e
treee170fda1311ec7037e536dce55d830bb6c2490bf
parent77ee1ca74317f8e2ffa1a5dcccaffa4081a508da
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers

    This patch adds aria-haspopup and aria-expanded attributes to the language
    and welcome user buttons so that screen readers will know that they cause a
    popup menu to be displayed.

    To test:
    1. Use an installation with at least 2 active languages
    2. Log in the OPAC
    3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to
       navigate to the language and welcome user buttons while noticing that
       they are described as "Button collapsed" and "Button", respectively
    4. Alternatively, inspect the buttons and notice that they are missing
       aria-haspopup and aria-expanded attributes
    5. Apply the patch
    6. Observe that these buttons now are described as "Popup button collapsed"
       or that they contain the aria-haspopup and aria-expanded attributes like
       the lists button
    7. Sign off

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc