]> git.koha-community.org Git - koha.git/commit
Bug 22948: Markup error in OPAC bibliographic detail template
authorOwen Leonard <oleonard@myacpl.org>
Tue, 21 May 2019 14:27:40 +0000 (14:27 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 10 Jun 2019 14:56:03 +0000 (16:56 +0200)
commit1baddd190fe1ed72e66298a6b01394e86e58d0fe
treec7a1f2d2762c11d3d86b5fe360c5589079193c11
parenta4dea8c8b802bf5e1b4985762885565ad7c49e75
Bug 22948: Markup error in OPAC bibliographic detail template

This patch addresses one markup problem in opac-detail.tt which triggers
a validation error.

To reproduce the problem, view the normal bibliographic detail page for
a record in the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "The aria-labelledby attribute must point to an element in the same
   document."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Test the "Save record -> Dublin Core" menu item. It should trigger a
modal window.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a3da6d6825f686099d8e23a1abff061071d679ad)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc