]> git.koha-community.org Git - koha.git/commit
Bug 18996: [QA Follow-up] Remove global variables from Message.t
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 2 Aug 2017 11:01:47 +0000 (13:01 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 20 Aug 2017 11:27:27 +0000 (08:27 -0300)
commit37d07b28ce4089f691631bde3f6e9a2fe7b81b10
treea0c0acb195a0083355af0e83004ddab7df1f7a5e
parent2490401be149d825108fc9c9f8bf556e64e2323d
Bug 18996: [QA Follow-up] Remove global variables from Message.t

As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.

Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/SIP/Message.t