From 2b3e8b25418625b3e38db381f3981ade8bc5f7b5 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Thu, 23 Feb 2023 20:26:23 +0000 Subject: [PATCH] Bug 33058: Update "fines" to "charges" for viewing a guarantees charges Charges includes fines and fees, while fines are mostly negative. Changing this according to our terminology guidelines. To test: * Make sure the patron category of your patron is set to be 'can be guarantee' in administration * Set AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor to allow * Set OpacPrivacy to allow * Edit your patron, give it a guarantor and look at the "Show fines to guarantors setting" and hint * Save and look at the label of the field on the details tab * Go to the OPAC and log in * Check the Privavy tab for the option to allow the guarantee to see your charges * Apply patch. Verify: * System preference descriptions changes * Option and label names have changed in all steps above Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3f848e4d244ce4fa5f9f8a6d507c79de704592b5) Signed-off-by: Matt Blenkinsop --- .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++-- .../prog/en/modules/admin/preferences/patrons.pref | 2 +- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 09e4439b4e..cb014ab6e0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -584,7 +584,7 @@ OPAC: - Only allow patrons to renew their own books on the OPAC if they have less than - pref: OPACFineNoRenewals class: currency - - '[% local_currency %] in fines (leave blank to disable).' + - '[% local_currency %] in charges (leave blank to disable).' - - pref: OPACFineNoRenewalsIncludeCredits choices: @@ -670,7 +670,7 @@ OPAC: choices: 1: Allow 0: "Don't allow" - - "patrons to choose their own privacy settings for showing the patron's fines to the patron's guarantor." + - "patrons to choose their own privacy settings for showing the patron's charges to the patron's guarantor." - - Use borrowernumber - pref: AnonymousPatron diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref index 685a09b2e6..b0638195a8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ -348,7 +348,7 @@ Patrons: choices: 1: Allow 0: "Don't allow" - - staff to set the ability for a patron's fines to be viewed by linked patrons in the OPAC. + - staff to set the ability for a patron's charges to be viewed by linked patrons in the OPAC. Privacy: - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index 9dd015b99e..10a4a4d601 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -610,7 +610,7 @@ legend:hover { [% END %] [% IF Koha.Preference('AllowStaffToSetFinesVisibilityForGuarantor') %]
  • - + -
    Allow guarantors of this patron to view this patron's fines from the OPAC
    +
    Allow guarantors of this patron to view this patron's charges from the OPAC
    • [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt index 0cb639a73d..9cadcd5709 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -200,7 +200,7 @@
  • - Show fines to guarantor + Show charges to guarantor [% IF patron.privacy_guarantor_fines %] Yes [% ELSE %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt index 1ca4b28944..1d3c155f08 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt @@ -121,7 +121,7 @@ [% IF Koha.Preference('AllowPatronToSetFinesVisibilityForGuarantor') %]
    - +