From 367f19f6273fa26af9e653625156da0dba9dfc17 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 5 Mar 2021 15:33:02 +0000
Subject: [PATCH] Bug 27881: Markup error in masthead-langmenu.inc

Some markup errors were introduced into the masthead-langmenu include
file by Bug 20168, presumably during the update to the dropdown menu
markup:

'<a class="dropdown-item" <a href="'

...resulting in validation errors like "Attribute <a not allowed on
element a at this point." This patch correct the errors.

To test you should have at least two languages enabled in the
OPACLanguages system preference, opaclanguagesdisplay set to "allow,"
and OpacLangSelectorMode set to "top" or "both top and footer."

- Apply the patch and view the OPAC.
- The "Languages" menu at the top of the page should look correct and
  work correctly.
- Validating the source of the page should return no errors related to
  the language menu's markup.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
index a578f3275c..c80d978837 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc
@@ -11,16 +11,16 @@
                                 [% FOREACH sublanguages_loo IN languages_loo.sublanguages_loop %]
                                     [% IF ( sublanguages_loo.enabled ) %]
                                         [% IF ( sublanguages_loo.sublanguage_current ) %]
-                                            <a class="dropdown-item" <a href="#" tabindex="-1" role="menuitem">[% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %]&nbsp;<i class="fa fa-check" aria-hidden="true"></i></a>
+                                            <a class="dropdown-item" href="#" tabindex="-1" role="menuitem">[% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %]&nbsp;<i class="fa fa-check" aria-hidden="true"></i></a>
                                         [% ELSE %]
-                                            <a class="dropdown-item"<a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag | uri %]"  tabindex="-1" role="menuitem"> [% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %]</a>
+                                            <a class="dropdown-item" href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag | uri %]"  tabindex="-1" role="menuitem"> [% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %]</a>
                                         [% END # /IF ( sublanguages_loo.sublanguage_current ) %]
                                     [% END # / IF sublanguages_loo.enabled %]
                                 [% END # / FOREACH sublanguages_loo %]
                             [% ELSE %]
                                 [% IF ( languages_loo.group_enabled ) %]
                                     [% IF ( languages_loo.current ) %]
-                                        <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem">
+                                        <a class="dropdown-item" href="#" tabindex="-1" class="menu-inactive" role="menuitem">
                                             [% IF ( languages_loo.native_description ) %]
                                                 [% languages_loo.native_description | html %]
                                             [% ELSE %]
@@ -28,7 +28,7 @@
                                             [% END %]&nbsp;<i class="fa fa-check" aria-hidden="true"></i>
                                         </a>
                                     [% ELSE %]
-                                        <a class="dropdown-item"<a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag | uri %]"  tabindex="-1" role="menuitem">
+                                        <a class="dropdown-item" href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag | uri %]"  tabindex="-1" role="menuitem">
                                             [% IF ( languages_loo.native_description ) %]
                                                 [% languages_loo.native_description | html %]
                                             [% ELSE %]
-- 
2.39.5