From 639dda850db7832a0fb6d06db6d270f804228eac Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 21 May 2019 12:39:09 +0000
Subject: [PATCH] Bug 22946: Markup error in OPAC search results around
 selection links

This patch makes minor corrections to the template for OPAC search
results. These corrections fix errors returned by the HTML validator.

To reproduce the problem, make sure holds and/or tags are enabled in the
OPAC. Perform a search in the OPAC which will return multiple results.
Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses one specific error:

 - "Element div not allowed as child of element span in this context."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the search results view.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 48259267f6830b2e388b2a91268117645bda80f3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
index 9595b2a5a9..211f0d180f 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ -189,15 +189,15 @@
                                                 <span id="tagsel_span">
                                                     <input id="tagsel_tag" class="disabled" type="submit" value="Tag"/>
                                                 </span>
-                                                <div id="tagsel_form" style="display:none">
+                                                <span id="tagsel_form" style="display:none">
                                                     <label for="tagsel_new">New tag:</label>
                                                     <input type="text" name="tagsel_new" id="tagsel_new" maxlength="100" />
                                                     <input id="tagsel_button" name="tagsel_button" class="tagsel_button btn btn-small" title="Add" type="submit" value="Add" />
                                                     <a href="#" id="tagsel_cancel">(done)</a>
-                                                </div>
-                                                <div id="tagsel_status" class="tagsel_tatus" style="display:none;">
+                                                </span>
+                                                <span id="tagsel_status" class="tagsel_tatus" style="display:none;">
                                                     Tag status here.
-                                                </div>
+                                                </span>
                                             [% END %]
                                         </span> <!-- / .links -->
                                 </div> <!-- / #selections-toolbar -->
-- 
2.39.5