From 7495bf9706cef54583676e7c15aa5103aacbf1a5 Mon Sep 17 00:00:00 2001 From: Blou Date: Wed, 3 Feb 2021 11:46:33 -0500 Subject: [PATCH] Bug 27608: [20.05] Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Sponsored-by: Collecto Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer JD Amended patch: Add sponsor line Signed-off-by: Andrew Fuerste-Henry --- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 845df295f1..74847145ae 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -397,7 +397,7 @@ [% INCLUDE 'date-format.inc' %] - [% IF ( acceptedby_patron.borrowernumber ) %][% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %]) [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %])[% END %] + [% IF ( acceptedby_patron.borrowernumber ) %][% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% acceptedby_patron.cardnumber | html %]) [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %])[% END %] -- 2.39.5