From 74ac5baba5a618174aed679256a274dcdef10166 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 16 Mar 2018 15:18:15 -0300 Subject: [PATCH] Bug 20438: Allow uninstalling plugins not implementing the 'uninstall' method The plugins handling code expects plugins implementing an 'uninstall' method for cleanup purposes. It executes this method, and then moves on with removing the configuration entries in the storage, and the plugin itself. But the 'plugins-home.tt' template makes the tool display the 'Uninstall' link in the dropdown ONLY when the plugin has the 'uninstall' method. This patch fixes the issue. To reproduce: - Install the KitchenSink plugin [1] => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Edit the code for the plugin: $ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm - Remove the uninstall sub - Restart everything: $ restart_all - Reload the browser => FAIL: There's no 'Uninstall' option in the actions dropdown. - Apply this patch - Restart everything $ restart_all - Reload the browser => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Sign off :-D [1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt | 2 -- 1 file changed, 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt index a2c91d4cbd..4f895f4c77 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt @@ -113,9 +113,7 @@ [% END %] [% END %] [% IF ( CAN_user_plugins_manage ) %] - [% IF plugin.can('uninstall') %]
  • Uninstall
    • - [% END %] [% END %] -- 2.39.5