From 8aea1ca0f62acf00b8ffdb881b7293f7c598acd3 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 31 Oct 2017 13:17:26 +0000 Subject: [PATCH] Bug 19551: Fix wrong order of operations in cash register report To test: 1 - Find or create a fine for a patron 2 - Write it off 3 - Home -> Reports -> Cash register 4 - Fill in current date and transaction type 'Write off' 5 - Click Submit -- see your write off 6 - Fill in previous dates and transaction type 'Write off' 7 - Click Submit -- see your write off (bad) 8 - Apply patch 9 - Rerun steps 3-7 -- write only visible for current date. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- reports/cash_register_stats.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl index 158625dc7a..0a1ff54fcc 100755 --- a/reports/cash_register_stats.pl +++ b/reports/cash_register_stats.pl @@ -75,7 +75,7 @@ if ($do_it) { $whereTType = q{ AND accounttype IN ('Pay','C') }; } else { #Single transac type if ($transaction_type eq 'FORW') { - $whereTType = q{ AND accounttype = 'FOR' OR accounttype = 'W' }; + $whereTType = q{ AND accounttype IN ('FOR','W') }; } else { $whereTType = q{ AND accounttype = ? }; push @extra_params, $transaction_type; -- 2.39.5