From 8e3901342a8e2de8290cc5d86e49f809e67e764d Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 4 Aug 2023 10:32:17 +0200
Subject: [PATCH] Bug 34478: Replace get with post when needed

This is what has been marked as done in "csrf_get.txt"

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/patroncards/edit-layout.tt            | 2 +-
 .../prog/en/modules/patroncards/edit-profile.tt           | 2 +-
 .../prog/en/modules/patroncards/edit-template.tt          | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt        | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt   | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt  | 2 +-
 .../bootstrap/en/includes/opac-detail-sidebar.inc         | 2 +-
 .../bootstrap/en/modules/opac-authorities-home.tt         | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt   | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt  | 8 ++++----
 10 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt
index 827251ebb7..fc2108d0f1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt
@@ -59,7 +59,7 @@
                     </h1>
 
                 <!-- NOTE: The order of the elements on this form is crictical to correct processing. You've been warned...  -->
-                <form name="input" action="/cgi-bin/koha/patroncards/edit-layout.pl" method="get">
+                <form name="input" action="/cgi-bin/koha/patroncards/edit-layout.pl" method="post">
                 <div class="row">
                 <div class="col-sm-6">
                         <fieldset class="rows">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt
index 60dc489460..4b9e37d93e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt
@@ -57,7 +57,7 @@
                                     <span>New printer profile</span>
                                 [% END%]
                             </h1>
-                                    <form name="input" action="/cgi-bin/koha/patroncards/edit-profile.pl" method="get">
+                                    <form name="input" action="/cgi-bin/koha/patroncards/edit-profile.pl" method="post">
                                     <fieldset class="rows"><legend>Profile settings</legend>
                                         <ol>
                                             <li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt
index 0c09c743fe..087940e7f1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt
@@ -58,7 +58,7 @@
                         [% END %]
                         [% IF (template_id) %] ([% template_id | html %])[% END %]
                     </h1>
-                    <form name="input" action="/cgi-bin/koha/patroncards/edit-template.pl" method="get">
+                    <form name="input" action="/cgi-bin/koha/patroncards/edit-template.pl" method="post">
                         <div class="row">
                         <div class="col-sm-6">
                             <fieldset class="rows">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
index fe2c71859d..3978cbed53 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
@@ -43,7 +43,7 @@
                     You must have at least one cash register associated with the library before you can record payments.
                 </p>
                 [% IF ( CAN_user_parameters_manage_cash_registers ) %]
-                    <form action="/cgi-bin/koha/admin/cash_registers.pl" method="get">
+                    <form action="/cgi-bin/koha/admin/cash_registers.pl" method="post">
                         <input type="hidden" name="op" value="add_form" />
                         <button class="new" type="submit"><i class="fa fa-plus"></i> Create a new cash register</button>
                     </form>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
index df94cba635..3ff6f0ed31 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
@@ -40,7 +40,7 @@
                         You must have at least one cash register associated with the library before you can record payments.
                     </p>
                     [% IF ( CAN_user_parameters_manage_cash_registers ) %]
-                        <form action="/cgi-bin/koha/admin/cash_registers.pl" method="get">
+                        <form action="/cgi-bin/koha/admin/cash_registers.pl" method="post">
                             <input type="hidden" name="op" value="add_form" />
                             <button class="new" type="submit"><i class="fa fa-plus"></i> Create a new cash register</button>
                         </form>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt
index 52a0b0bdc7..d0b7cec62c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt
@@ -37,7 +37,7 @@
                                 You must have at least one cash register associated with the library before you can record payments.
                             </p>
                             [% IF ( CAN_user_parameters_manage_cash_registers ) %]
-                                <form action="/cgi-bin/koha/admin/cash_registers.pl" method="get">
+                                <form action="/cgi-bin/koha/admin/cash_registers.pl" method="post">
                                     <input type="hidden" name="op" value="add_form" />
                                     <button class="new" type="submit"><i class="fa fa-plus"></i> Create a new cash register</button>
                                 </form>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
index f1d4e60bdd..a91aa47569 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
@@ -118,7 +118,7 @@
                 <h3 class="modal-title" id="exportModalLabel">Exporting to Dublin Core...</h3>
                 <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">&times;</button>
             </div>
-            <form method="get" action="/cgi-bin/koha/opac-export.pl">
+            <form method="post" action="/cgi-bin/koha/opac-export.pl">
                 <div class="modal-body">
                     <fieldset id="dc_fieldset">
                         <input id="input-simple" type="radio" name="format" value="rdfdc">
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt
index f51909adc8..3603b8fe51 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt
@@ -31,7 +31,7 @@
                     <div class="col order-first order-md-first order-lg-2">
                 [% END %]
                     <div id="userauthhome" class="maincontent">
-                        <form name="f" action="/cgi-bin/koha/opac-authorities-home.pl" method="get">
+                        <form name="f" action="/cgi-bin/koha/opac-authorities-home.pl" method="post">
                             <input type="hidden" name="op" value="do_search" />
                             <input type="hidden" name="type" value="opac" />
                             <fieldset class="rows">
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
index 8bd3830b0e..c9d11fb9dc 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
@@ -61,7 +61,7 @@
                             [% IF logged_in_user %]
                                 <div class="dialog">
 
-                                    <form id="recallform" action="/cgi-bin/koha/opac-recall.pl" method="get">
+                                    <form id="recallform" action="/cgi-bin/koha/opac-recall.pl" method="post">
                                         <fieldset class="rows" id="options">
                                             <legend>Place a recall on <b>[% biblio.title | html %]</b> ([% biblio.author | html %])?</legend>
                                             <ul>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
index 78c3c1de65..4166f62b35 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ -244,7 +244,7 @@
 
                                         [% IF can_manage_shelf %]
                                             <span class="sep">|</span>
-                                            <form method="get" action="/cgi-bin/koha/opac-shelves.pl" class="d-inline">
+                                            <form method="post" action="/cgi-bin/koha/opac-shelves.pl" class="d-inline">
                                                 <input type="hidden" name="op" value="edit_form" />
                                                 <input type="hidden" name="referer" value="view" />
                                                 <input type='hidden' name='public' value='[% shelf.public | html %]' />
@@ -550,7 +550,7 @@
                                     <a class="btn btn-link newshelf" href="/cgi-bin/koha/opac-shelves.pl?op=add_form"><i class="fa fa-fw fa-plus" aria-hidden="true"></i> New list</a>
                                     [% IF can_manage_shelf %]
                                         <span class="sep">|</span>
-                                        <form method="get" action="/cgi-bin/koha/opac-shelves.pl" class="d-inline">
+                                        <form method="post" action="/cgi-bin/koha/opac-shelves.pl" class="d-inline">
                                             <input type="hidden" name="op" value="edit_form" />
                                             <input type="hidden" name="referer" value="view" />
                                             <input type="hidden" name="public" value="[% shelf.public | html %]" />
@@ -759,7 +759,7 @@
                                                     <td>[% s.lastmodified | $KohaDates %]</td>
                                                     <td>
                                                         [% IF s.can_be_managed( loggedinusernumber ) %]
-                                                            <form action="/cgi-bin/koha/opac-shelves.pl" method="get" class="d-inline">
+                                                            <form action="/cgi-bin/koha/opac-shelves.pl" method="post" class="d-inline">
                                                                 <input type="hidden" name="shelfnumber" value="[% s.shelfnumber | html %]" />
                                                                 <input type="hidden" name="public" value="[% s.public | html %]" />
                                                                 <input type="hidden" name="op" value="edit_form" />
@@ -774,7 +774,7 @@
                                                             <a href="/cgi-bin/koha/opac-shareshelf.pl?op=invite&shelfnumber=[% s.shelfnumber | uri %]" class="sharelist btn btn-link"><i class="fa fa-share" aria-hidden="true"></i> Share</a>
                                                         [% END %]
                                                         [% IF s.is_shared AND s.can_be_managed( loggedinusernumber ) %]
-                                                            <form action="/cgi-bin/koha/opac-shelves.pl" method="get" class="d-inline">
+                                                            <form action="/cgi-bin/koha/opac-shelves.pl" method="post" class="d-inline">
                                                                 <input type="hidden" name="shelfnumber" value="[% s.shelfnumber | html %]" />
                                                                 <input type="hidden" name="public" value="0" />
                                                                 <input type="hidden" name="op" value="transfer" />
-- 
2.39.5