From b3b976f189fc455f8f0ac553c99d6efb859d747f Mon Sep 17 00:00:00 2001 From: Josef Moravec Date: Thu, 9 Aug 2018 16:57:58 +0100 Subject: [PATCH] Bug 21154: Remove unused subs from C4::Serials Test plan: Run these commands, grep should not return any occurences, prove should return green: git grep GetSerialStatusFromSerialId git grep GetDistributedTo git grep SetDistributedTo git grep SetDistributedto git grep in_array git grep is_barcode_in_use kshell prove t/db_dependent/Serials.t Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens RMaint Comment: I have opted to replace this charry-pick with a deprecation warning rather than the removal of these routines outright. (cherry picked from commit 948566e7f36a75a186f96b5ee07b5120a5413ca5) Signed-off-by: Martin Renvoize --- C4/Serials.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/C4/Serials.pm b/C4/Serials.pm index 0f6256e091..14598410b2 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -173,6 +173,7 @@ $sth = $dbh->prepare($query). =cut sub GetSerialStatusFromSerialId { + warn "C4::Serials::GetSerialStatusFromSerialId will be deprecated as of 18.11.0\n"; my $dbh = C4::Context->dbh; my $query = qq| SELECT status @@ -853,6 +854,7 @@ This function returns the field distributedto for the subscription matching subs =cut sub GetDistributedTo { + warn "C4::Serials::GetDistributedTo will be deprecated as of 18.11.0\n"; my $dbh = C4::Context->dbh; my $distributedto; my ($subscriptionid) = @_; @@ -1726,6 +1728,7 @@ This function update the value of distributedto for a subscription given on inpu =cut sub SetDistributedto { + warn "C4::Serials::SetDistributedto will be deprecated as of 18.11.0\n"; my ( $distributedto, $subscriptionid ) = @_; my $dbh = C4::Context->dbh; my $query = qq| -- 2.39.5