From c6439db535ae78107a56152904013b69f9898732 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 14 Aug 2020 17:28:22 +0000
Subject: [PATCH] Bug 26216: Remove the use of jquery.checkboxes plugin from
 catalog search results

This patch removes the use of jquery.checkboxes plugin from the
staff interface catalog search results page.

To test, apply the patch and perform a catalog search in the staff
interface which will return results.

On the search results page test the "Select all" and "Clear all" links
at the top of the results. They should work correctly.

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit af8aa1ad7eb4857a86d395b3833b8040630306b6)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/modules/catalogue/results.tt |  1 -
 koha-tmpl/intranet-tmpl/prog/js/pages/results.js       | 10 +++-------
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
index 72cd9a00a4..b8b45d61a3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ -707,7 +707,6 @@
     [% INCLUDE 'strings.inc' %]
     [% Asset.js("js/browser.js") | $raw %]
     [% Asset.js("lib/hc-sticky.js") | $raw %]
-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
     [% Asset.js("js/coce.js") | $raw %]
     <script>
         var MSG_NO_ITEM_SELECTED = _("Nothing is selected.");
diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js
index 6c3a488575..d9978b08df 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/pages/results.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/results.js
@@ -164,7 +164,7 @@ $(document).ready(function() {
         }
     });
     $("#bookbag_form").ready(function(){
-        $("#bookbag_form").unCheckCheckboxes();
+        $("#bookbag_form input:checkbox").prop("checked", false);
         var bibnums = getContextBiblioNumbers();
         if (bibnums) {
             for (var i=0; i < bibnums.length; i++) {
@@ -211,18 +211,14 @@ function highlightOn() {
 
 
 function selectAll () {
-    $("#bookbag_form").checkCheckboxes();
     $("#bookbag_form").find("input[type='checkbox'][name='biblionumber']").each(function(){
-        $(this).change();
+        $(this).prop("checked", true ).change();
     } );
-    return false;
 }
 function clearAll () {
-    $("#bookbag_form").unCheckCheckboxes();
     $("#bookbag_form").find("input[type='checkbox'][name='biblionumber']").each(function(){
-        $(this).change();
+        $(this).prop("checked", false).change();
     } );
-    return false;
 }
 function placeHold () {
     var checkedItems = $(".selection:checked");
-- 
2.39.5