From c8369eb113bd3631683e958fa4bfc2289f4f81e2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 23 Oct 2018 10:15:11 -0300 Subject: [PATCH] Bug 21634: Keep "circulation" module selected when viewing patron's logs To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERS&modules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. Test plan: - Apply the patch - Click "Modification log" - Notice that the url now contains "modules=MEMBERS&modules=CIRCULATION" - Submit the form without changing any input/select from the form => Now you have the "members" and "circulation" modules selected. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit ad56b39888f1422606b16375b903fffa19bc59ba) Signed-off-by: Martin Renvoize (cherry picked from commit b638541d91584a7fd0260069330934084e1139f2) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 5c7ba97a61..acbb2960ec 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -94,7 +94,7 @@ [% END %] [% END %] [% IF ( CAN_user_tools_view_system_logs ) %] - [% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • + [% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • [% END %] [% IF ( CAN_user_borrowers ) %] [% IF ( sentnotices ) %]
  • [% ELSE %]
  • [% END %]Notices
    • -- 2.39.5