From cc23b3b91813f7ca0b1c15e470e8884c6e6a20aa Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date: Fri, 17 Jun 2022 09:28:27 +0000
Subject: [PATCH] Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 Koha/Item.pm                                                | 2 +-
 installer/data/mysql/atomicupdate/bug_28854.pl              | 0
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt     | 6 +++---
 4 files changed, 5 insertions(+), 5 deletions(-)
 mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug_28854.pl

diff --git a/Koha/Item.pm b/Koha/Item.pm
index e97867309f..fecdf5ddcf 100644
--- a/Koha/Item.pm
+++ b/Koha/Item.pm
@@ -1588,7 +1588,7 @@ sub add_to_bundle {
     }
     catch {
 
-        # FIXME: See if we can move the below copy/paste from Koha::Object::store into it's own class and catch at a lower level in the Schema instantiation.. take inspiration fro DBIx::Error
+        # FIXME: See if we can move the below copy/paste from Koha::Object::store into it's own class and catch at a lower level in the Schema instantiation, take inspiration from DBIx::Error
         if ( ref($_) eq 'DBIx::Class::Exception' ) {
             warn $_->{msg};
             if ( $_->{msg} =~ /Cannot add or update a child row: a foreign key constraint fails/ ) {
diff --git a/installer/data/mysql/atomicupdate/bug_28854.pl b/installer/data/mysql/atomicupdate/bug_28854.pl
old mode 100644
new mode 100755
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 1c7a5c2530..99550019db 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -1607,7 +1607,7 @@ Note that permanent location is a code, and location may be an authval.
 
         [% IF bundlesEnabled %]
         var bundle_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail','bundle_tables','json') | $raw %];
-        var bundle_lost_value = [% Koha.Preference('BundleLostValue') %];
+        var bundle_lost_value = [% Koha.Preference('BundleLostValue') | html %];
         [% END %]
         $(document).ready(function() {
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
index 6bd49ae180..d3fdc3291c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ -384,8 +384,8 @@
 
                             [% IF bundle_items && !missing_items %]
                                 <div class="dialog message">
-                                    <h3>Bundle varified</h3>
-                                    <p>The bundle content was varified</p>
+                                    <h3>Bundle verified</h3>
+                                    <p>The bundle content was verified</p>
                                     <p><a class="btn btn-default btn-xs" role="button" data-toggle="modal" href="#bundleContentsModal"><i class="fa fa-eye" aria-hidden="true"></i> View contents list</a></p>
                                 </div>
                             [% END %]
@@ -1558,7 +1558,7 @@
                         });
                     } else {
                         feedback.fadeOut(100, function(){
-                            string = _("Varified: ")+last;
+                            string = _("Verified: ")+last;
                             feedback.addClass('alert-success').removeClass('alert-danger').html(string).fadeIn(100);
                         });
                     }
-- 
2.39.5