From e102daaf310de6a64389e33f7c7fd473752c5e33 Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Fri, 24 Mar 2023 15:19:06 -1000
Subject: [PATCH] Bug 33336: Use a dedicated column for plugin status in
 plugins table

In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label.
With new interface ENABLED is yellow, this looks weird.
Also I bet this is bad for accessibility.

I propose to move this info to a dedicated column.
I use bootstrap classes bg-success and bg-warning like in about.pl

Test plan:
1) Install some plugins
2) Go to Administration > Manage plugins
3) Check you see table with column status
4) Disable a plugin
5) Check you see 'Disabled' in status

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/plugins/plugins-home.tt         | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
index 0ee44d36b8..9aa516a0d9 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
@@ -122,6 +122,7 @@
                                         <th>Minimum Koha version</th>
                                         <th>Maximum Koha version</th>
                                         <th>Last updated</th>
+                                        <th>Status</th>
                                         [% IF ( CAN_user_plugins_configure || CAN_user_plugins_manage || CAN_user_plugins_report || CAN_user_plugins_tool ) %]
                                             <th class="noExport">Actions</th>
                                         [% END %]
@@ -145,11 +146,6 @@
                                     <tr>
                                         <td>
                                             <strong>[% plugin.metadata.name | html %]</strong>
-                                            [% IF ( plugin.is_enabled ) %]
-                                                <span class="label label-primary">ENABLED</span>
-                                            [% ELSE %]
-                                                <span class="label label-default">DISABLED</span>
-                                            [% END %]
                                         </td>
                                         <td>
                                             [% plugin.metadata.description | html %]
@@ -171,6 +167,13 @@
                                         <td>[% plugin.metadata.minimum_version | html %]</td>
                                         <td>[% plugin.metadata.maximum_version | html %]</td>
                                         <td>[% plugin.metadata.date_updated | $KohaDates %]</td>
+                                        <td>
+                                            [% IF ( plugin.is_enabled ) %]
+                                                <span class="bg-success">Enabled</span>
+                                            [% ELSE %]
+                                                <span class="bg-warning">Disabled</span>
+                                            [% END %]
+                                        </td>
                                         [% IF ( CAN_user_plugins_configure || CAN_user_plugins_manage || CAN_user_plugins_report || CAN_user_plugins_tool ) %]
                                             <td class="actions">
                                                 <div class="btn-group dropup">
-- 
2.39.5