From f681964591ba1efde4c1c8c032c344b85c1d1815 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 14 Aug 2020 14:18:00 +0000
Subject: [PATCH] Bug 26213: Remove the use of jquery.checkboxes plugin when
 adding orders from MARC file

This patch removes the use of the jquery.checkboxes plugin from the page
for adding orders to a basket from a staged MARC file.

This patch fixes an unreported bug wherein the "select all" and "clear
all" controls affected not only MARC record checkboxes but also the
"show inactive funds" checkboxes.

To test, apply the patch and go to Acquisitions.

- Go to Vendor -> Add to basket -> From a staged file.
- Select a staged file with multiple records.
- Test the "Select all" and "Clear all" links at the top of the "Select
  to import" tab. They should work correctly to select and deselect
  checkboxes corresponding to staged MARC records.

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 8344ee7b4ced266ac7bd48254f4695175fd8f19b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/acqui/addorderiso2709.tt       |  1 -
 koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 14 ++++++--------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
index 0e07f20cff..ebe364e3cb 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
@@ -15,7 +15,6 @@
 [%# As long as cataloging plugins rely on <script> tags added inline, JS must be in the header %]
 [% Asset.js("js/acquisitions-menu.js") | $raw %]
 [% INCLUDE 'datatables.inc' %]
-[% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
 [% Asset.js("js/acq.js") | $raw %]
 [% Asset.js("js/funds_sorts.js") | $raw %]
 [% Asset.js("js/addorderiso2709.js") | $raw %]
diff --git a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
index 8382532a64..04b8851936 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
@@ -37,15 +37,13 @@ $(document).ready(function() {
     $("div.biblio.unselected select").prop('disabled', false);
     $("div.biblio.unselected input").prop('disabled', false);
 
-    $("#checkAll").click(function(){
-        $("#Aform").checkCheckboxes();
-        $("input:checkbox[name='import_record_id']").change();
-        return false;
+    $("#checkAll").click(function(e){
+        e.preventDefault();
+        $("input:checkbox[name='import_record_id']").prop("checked", true).change();
     });
-    $("#unCheckAll").click(function(){
-        $("#Aform").unCheckCheckboxes();
-        $("input:checkbox[name='import_record_id']").change();
-        return false;
+    $("#unCheckAll").click(function(e){
+        e.preventDefault();
+        $("input:checkbox[name='import_record_id']").prop("checked", false).change();
     });
 
     $("input#add_order").on("click", function(e){
-- 
2.39.5