]> git.koha-community.org Git - koha.git/commit
Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0
authorPhil Ringnalda <phil@chetcolibrary.org>
Thu, 28 Mar 2024 22:02:38 +0000 (15:02 -0700)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 28 May 2024 16:25:41 +0000 (16:25 +0000)
commit2a23a3320f08dc4ae85b81da64ccb5bdd5a486de
tree6a0b73d030c33c1d7b1bb43e0e16538179f8f4d4
parent88757883797c1e24f14fa3f0bf5c96fa6373eda7
Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0

We aren't actually doing any error handling with the RequireJS waitSeconds
config, just leaving the advanced editor hanging on loading if it times out,
so instead we should disable it.

Test plan:

1. Set the preference EnableAdvancedCatalogingEditor to Enable
2. Load the Cataloging module home page in Firefox and open Firefox's
   Web Developer Tools, and in the Network tab change from "No Throttling"
   to "Regular 2G"
3. In the Cataloging page, click Advanced editor, and watch it attempt to
   load for 30 seconds, followed by a setTimout error in the devtools console,
   and then wait as long as you can stand for anything but the "Loading,
   please wait..." to happen in the web page. Nothing ever will.
4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to
   Enable, turn throttling on, load the Advanced editor again, and note that
   even though it will take a minute or more to load through the throttling,
   the editor does actually load.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 95394217f081a38c3fe66f21d673aa056c83414b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit c305b468218bee1ece2e396762d2360ed628d71c)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc