]> git.koha-community.org Git - koha.git/commit
Bug 36520: Sanitize input in opac-sendbasket.pl
authorChris Cormack <chris@bigballofwax.co.nz>
Mon, 13 May 2024 02:26:13 +0000 (02:26 +0000)
committerWainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Fri, 31 May 2024 03:05:15 +0000 (03:05 +0000)
commited1c3b53b0b4986848ff1c1ac8bb2c2773856269
treead9c72940c466d2de34fe0974dd76efebb2a787e
parent6adc9829bf2d15f07c953c9999363541a864903d
Bug 36520: Sanitize input in opac-sendbasket.pl

To test
1/ Add some items to your cart in the opac
2/ Choose send cart
3/ Open firefox developer tools and switch to the network tab
4/ Send cart
5/ In the network tab, find the post request and choose copy as curl
6/ Edit the curl command to add )+AND+(SELECT+1+FROM+(SELECT(SLEEP(6)))x)--+-  to the bib_list parameter
7/ Run the curl notice it takes a long time to respond, if you want to check run the curl without the above part added
8/ Apply the patch and restart plack
9/ Run the modified curl and notice no longer the slow down
10/ Test in browser and make sure the basket is still sent

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
opac/opac-sendbasket.pl