]> git.koha-community.org Git - koha.git/commit
Bug 38177: Do not use stash to retrieve parameters
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 16 Oct 2024 08:11:24 +0000 (10:11 +0200)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Wed, 23 Oct 2024 17:14:51 +0000 (19:14 +0200)
commit61b3aa2aa298b46835d729f77a6a44a0d0faaa05
treef7e850339d6ace13410715d901abec2099a86151
parent8e5774cdfe24de1ec9a15d836a71a72039e8ca3d
Bug 38177: Do not use stash to retrieve parameters

The pagination for EBSCO's titles, packages and resources is broken. We
shouldn't rely on $c->stash but use params from the request instead.

Test plan:
1) Setup all the system preferences in ERM:
<staff_url>/cgi-bin/koha/admin/preferences.pl?tab=erm
2) Enable EBSCO in ERMProviders. Set the ERMProviderEbscoApiKey and ERMProviderEbscoCustomerID prefs.
3) Do a search that returns more than 20 records. Click on a page other than 1. Notice the records do not change (Page is the same).
4) Apply patch. Repeat. Notice pagination now works.

Search titles, packages and resources
Use the pagination and modify the number of results per page

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/ERM/Providers/EBSCO.pm
Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm
Koha/REST/V1/ERM/EHoldings/Resources/EBSCO.pm
Koha/REST/V1/ERM/EHoldings/Titles/EBSCO.pm