]> git.koha-community.org Git - koha.git/commit
Bug 37623: Make t/db_dependent/Letters.t idempotent
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 13 Aug 2024 03:07:17 +0000 (03:07 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 21 Oct 2024 12:23:29 +0000 (14:23 +0200)
commit58066cbd14de44c1b6b7eaeef139bf008cc52226
treeafff5fa9309a466d17d85a61688a3efceeb16443
parent95561abe1f4cc9ad259e73d7e83b81f1d27b320b
Bug 37623: Make t/db_dependent/Letters.t idempotent

The tests should be unaffected by system preference settings, such as EmailFieldPrimary.

To test:
1. Log into the staff interface
2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary
3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following:

* alternate email
* card number
* secondary email
* selected addresses

4. Run tests t/db_dependent/Letters.t and notice they fail

5. Apply the patch

6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 0e61e56e5728fc0ed387e9a53f40a6e77e9bc793)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit ca17ec1ce3b352938a811ff56c2b4afaf6e0eb63)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/db_dependent/Letters.t