]> git.koha-community.org Git - koha.git/commit
Bug 13940 : Testing C4::OAI::Sets
authorJulian FIOL <julian.fiol@biblibre.com>
Fri, 27 Mar 2015 13:44:01 +0000 (14:44 +0100)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 9 Apr 2015 14:56:41 +0000 (11:56 -0300)
commit975b055c08f7e0a6b2b00b0de04d899b8b318743
treeac386a056e70ceaa7ee6387f0968ef71a30fcb11
parentbde795f8fa488a2284d1d23667fb489bea6343f9
Bug 13940 : Testing C4::OAI::Sets

Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t
Adding &DelOAISetsBiblio in @EXPORT at the beginning
of OAI/Sets.pm, it was the only one missing

TEST PLAN
---------

1. Apply patch
2. prove -v t/db_dependent/OAI/Sets.t
-- All 145 tests should run successfully without any error or warning
3. Run koha qa test tools
   -- No issues found.

Additionally, I comfirmed why DelOAISetsBiblio was added in
the list of exported functions.

$ grep "^sub " C4/OAI/Sets.pm | sort > check1
$ for i in `grep "\&[A-Z]" C4/OAI/Sets.pm | xargs `; do echo $i; done | sort > check2

Of course the outputs have a little extra around them, so
$ vi check1
$ vi check2
$ diff check1 check2

Lo and behold, it was that one function. Necessary for 100% coverage.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/OAI/Sets.pm
t/db_dependent/OAI/Sets.t [new file with mode: 0644]