]> git.koha-community.org Git - koha.git/commit
Bug 22052: Refactor DeleteExpiredOpacReigstrations
authorNick Clemens <nick@bywatersolutions.com>
Fri, 28 Dec 2018 18:48:25 +0000 (18:48 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 8 Jan 2019 14:02:43 +0000 (14:02 +0000)
commitb32756a5d7819e13290c2a145f3f0009280785c4
treeee43cda376c90f27c32b0d6188d1268a6495272f
parentf44e37b201d0a8b95b1eee0ac0766bed9c386fc2
Bug 22052: Refactor DeleteExpiredOpacReigstrations

This patch changes the sub to use Koha::Objects and updates the tests.
Previously the sub would die on borrowers with checkouts and would
delete borrowers if they had fines

To test:
 1 - prove -v t/db_dependent/
 2 - Set your selfreg preferences:
    PatronSelfRegistration: Allow
    PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
    PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
 3 - Register a patron into SELFREG or how you set above
 4 - Set their date enrolled to two months ago
 5 - Checkout an item to the patron
 6 - Issue a fine to that patron
 7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
 8 - The job should die with an error
 9 - Check in the item
10 - run the corn again - patron is deleted, oops
11 - Apply patch
12 - Create another patron in the same way
13 - Checkout and fine the patron
14 - run the cron
15 - they are not deleted, and no error
16 - checkin the item
17 - run the cron
18 - they are not deleted and no error
19 - clear the fine
20 - run the cron
21 - patron is deleted, huzzah

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Members.pm