From 8583d09b55ec59118e0ec62854994e1ddab531b1 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 12 Apr 2023 11:49:51 +0100 Subject: [PATCH] Bug 33504: Update patron_to_html to deal with null In the patron_to_html function we were dealing explicitly with the case where patron may be passed undefined, but forgetting that it may be returned as 'null' from the api too. Changing from `( patron === undefined )` to `( patron == null )` is the recommended approach for detecting 'undefined or null' in javascript. Signed-off-by: Magnus Enger Works as advertised. Martin's test plan from Bugzilla: To test. 1) Use ILS-DI to renew an checkout 2) View the circulation history for the item 3) Click the 'View' button next to the count of renewals 4) Note that the modal just stalls at 'Retrieving renewals' 5) Apply the patch 6) Now the 'retrieving renewals' message should list the renewals instead. Note that step 2 should be something like "Go to the "Circulation history" of the patron. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 744ac4825ba9a346e2ad1c8e413d3d9423658512) Signed-off-by: Martin Renvoize (cherry picked from commit 31db36fb34843efe42ef3257d3d187c8611a53f7) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc index 0c1daae17f..904eefd116 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc @@ -9,7 +9,7 @@ */ window.$patron_to_html = function( patron, config ) { - if ( patron === undefined ) { + if ( patron == null ) { return ''; // empty string for no patron } -- 2.39.5