From 7297157533fd7d446a43445035d8cfb500d6df8c Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 12 Jan 2017 11:14:34 +1100 Subject: [PATCH] Bug 17880 - Add test to check version number comparison Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 2321ae0d796fa6b13cde8f321b6c697cc48a5437) Signed-off-by: Katrin Fischer --- t/Installer_PerlModules.t | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/t/Installer_PerlModules.t b/t/Installer_PerlModules.t index 1d5a00c4d4..fafdd48e8d 100755 --- a/t/Installer_PerlModules.t +++ b/t/Installer_PerlModules.t @@ -6,12 +6,22 @@ use strict; use warnings; -use Test::More tests => 17; +use Test::More tests => 19; BEGIN { use_ok('C4::Installer::PerlModules'); } +$C4::Installer::PerlModules::PERL_DEPS->{'Local::Module::Sort'} = { + 'required' => '1', + 'min_ver' => '0.9.3', + 'usage' => "Testing: make sure numbers are compared numerically and not lexicographically", +}; + +$Local::Module::Sort::VERSION = '0.9.13'; +$INC{"Local/Module/Sort.pm"} = 1; +use_ok("Local::Module::Sort"); + my $modules; ok ($modules = C4::Installer::PerlModules->new(), 'Tests modules object'); my $prereq_pm = $modules->prereq_pm(); @@ -37,3 +47,5 @@ my @module_list = $modules->module_list; ok (exists($params{"DBI"}), 'DBI exists in array'); is ($modules->required('module'=>"String::Random"),1, 'String::Random should return 1 since required'); ok (!$modules->version_info(), "Testing empty modules"); + +is($modules->version_info('module'=>"Local::Module::Sort")->{"Local::Module::Sort"}->{"upgrade"},0,"Version 0.9.13 is greater than 0.9.3, so no upgrade needed"); -- 2.39.5