From 74b78a40818e762375830f6a5c92fc8f9dbbc0bb Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 26 Nov 2014 13:51:45 +1300 Subject: [PATCH] fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Signed-off-by: wajasu Signed-off-by: Kyle M Hall Signed-off-by: Mason James --- cataloguing/addbiblio.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index 118bfc2db1..9815c580cb 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -665,8 +665,8 @@ sub build_tabs { foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) { next if ( length $subfield != 1 ); next - if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -5 ) - or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 4 ) ) + if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -4 ) + or ( $tagslib->{$tag}->{$subfield}->{hidden} >= 5 ) ) and not ( $subfield eq "9" and exists($tagslib->{$tag}->{'a'}->{authtypecode}) and defined($tagslib->{$tag}->{'a'}->{authtypecode}) and -- 2.39.5