From e04bdc226ef2e9b08123f2a1652e0532e8c7c3c7 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Fri, 9 Jun 2017 13:01:14 -0400 Subject: [PATCH] Bug 18771: CGI.pm: Subroutine multi_param redefined The commands in the test plan are examples, and may need varying depending on your installation. This was created as a result of attempting to clean the installation process up. However, I believe the redefine might exist normally too. I just didn't check. This is tested on a Debian 8 box sudo apt-get update'd fully. TEST PLAN --------- empty error log $ echo > ~/koha-dev/var/log/koha-error_log drop and recreate and empty db > drop database koha_library; > create database koha_library; > quit run the web installer, but DO NOT LOG IN! *opening chrome to Staff Client URL* check the error log $ less ~/koha-dev/var/log/koha-error_log ... [Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client 192.168.71.101:58169] AH01215: [Fri Jun 9 13:08:52 2017] CGI.pm: Subroutine multi_param redefined at /usr/share/perl5/CGI.pm line 419. ... apply patch empty error log $ echo > ~/koha-dev/var/log/koha-error_log refresh the installation login page recheck the error log $ less ~/koha-dev/var/log/koha-error_log notice no reference to "Subroutine multi_param redefined" run koha qa test tools Notice that it is just a require CGI; and comment added. Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit d222da0602ba96f08cc6c026f39451b0aa7de01e) Signed-off-by: Fridolin Somers (cherry picked from commit 037e056c0451e1d383a414e47573f5a4cece9677) Signed-off-by: Katrin Fischer --- C4/Context.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Context.pm b/C4/Context.pm index 15b898de3b..4bd41c5089 100644 --- a/C4/Context.pm +++ b/C4/Context.pm @@ -80,6 +80,7 @@ BEGIN { # Redefine multi_param if cgi version is < 4.08 # Remove the "CGI::param called in list context" warning in this case + require CGI; # Can't check version without the require. if (!defined($CGI::VERSION) || $CGI::VERSION < 4.08) { no warnings 'redefine'; *CGI::multi_param = \&CGI::param; -- 2.39.5