]> git.koha-community.org Git - koha.git/log
koha.git
10 years agoBug 11232: NORMARC facet definition and updated XSL file for DOM
Tomas Cohen Arazi [Thu, 4 Sep 2014 16:24:13 +0000 (13:24 -0300)]
Bug 11232: NORMARC facet definition and updated XSL file for DOM

This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based
on what is hardcoded on C4::Koha::getFacets().

The biblio-zebra-indexdefs.xsl file for NORMARC is generated using the usual:

xsltproc ...koha-indexdefs-to-zebra.xsl ...normarc/biblios/biblio-koha-indexdefs.xml > \
    ...normarc/biblios/biblio-zebra-indexdefs.xsl

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: David Cook <dcook@prosentient.com.au>
Seems to work with DOM and MARC21.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11232: UNIMARC facet definition and updated XSL file for DOM
Tomas Cohen Arazi [Thu, 4 Sep 2014 16:12:52 +0000 (13:12 -0300)]
Bug 11232: UNIMARC facet definition and updated XSL file for DOM

This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based
on what is hardcoded on C4::Koha::getFacets().

The biblio-zebra-indexdefs.xsl file for UNIMARC is generated using the usual:

xsltproc ...koha-indexdefs-to-zebra.xsl ...unimarc/biblios/biblio-koha-indexdefs.xml > \
    ...unimarc/biblios/biblio-zebra-indexdefs.xsl

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: David Cook <dcook@prosentient.com.au>
Seems to work with DOM and MARC21.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11232: MARC21 facet definition and updated XSL file for DOM
Tomas Cohen Arazi [Thu, 4 Sep 2014 16:12:09 +0000 (13:12 -0300)]
Bug 11232: MARC21 facet definition and updated XSL file for DOM

This patch adds the facets definitions to the biblio-koha-indexdefs.xml, based
on what is hardcoded on C4::Koha::getFacets().

The biblio-zebra-indexdefs.xsl file for MARC21 is generated using the usual:

xsltproc ...koha-indexdefs-to-zebra.xsl ...marc21/biblios/biblio-koha-indexdefs.xml > \
    ...marc21/biblios/biblio-zebra-indexdefs.xsl

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: David Cook <dcook@prosentient.com.au>
Seems to work with DOM and MARC21.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11232: Add new syntax for facets definition on koha-indexdefs-to-zebra.xsl
Tomas Cohen Arazi [Thu, 4 Sep 2014 16:11:07 +0000 (13:11 -0300)]
Bug 11232: Add new syntax for facets definition on koha-indexdefs-to-zebra.xsl

This patch changes koha-indexdefs-to-zebra.xsl to correctly process a new syntax
for defining facet indexes on the XML files.

It also changes the retrieval file to allow access to Zebra's internal data from
Zoom (i.e. access to zebra::facet:*).

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: David Cook <dcook@prosentient.com.au>
Seems to work with DOM and MARC21.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12957: Get rid of warnings in aqbudgets.pl
Jonathan Druart [Thu, 18 Sep 2014 10:56:50 +0000 (12:56 +0200)]
Bug 12957: Get rid of warnings in aqbudgets.pl

There are a lot of warnings on navigating into the fund views (list,
editing, etc.)

"Use of uninitialized value in string eq..."
"Use of uninitialized value in hash element"
"Use of uninitialized value in concatenation..."

Test plan:
Verify the warnings don't appear anymore in logs on going on the fund
list view, editing a fund, saving a fund.

QA note: the budget_owner_name, budget_borrowernumber and branchname are
never used on the fund list view. A call to GetMember has been removed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This seems to work nicely reducing the amount of noise in the log
considerably.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 13052 - OPAC Cart JavaScript is included twice in the footer
Owen Leonard [Thu, 9 Oct 2014 13:40:26 +0000 (09:40 -0400)]
Bug 13052 - OPAC Cart JavaScript is included twice in the footer

The external JavaScript file which powers the OPAC Cart should not be
included twice. The correct instance is the one which comes after the
definition of MSG strings.

To test you must have the opacbookbag system preference turned on. In
Bootstrap OPAC, test adding some items to the Cart and confirm that Cart
operations work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Cart is still working as expected, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12929 [QA Followup] - Hide borrownumber from sample csv file
Kyle M Hall [Fri, 10 Oct 2014 11:37:32 +0000 (07:37 -0400)]
Bug 12929 [QA Followup] - Hide borrownumber from sample csv file

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Works as described, hides the borrowernumber from the list
of fields to edit and also brings back the list of fields
for the sample file in the documentation.

Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12929: Restore behavior before bug 12716
Jonathan Druart [Tue, 16 Sep 2014 14:26:52 +0000 (16:26 +0200)]
Bug 12929: Restore behavior before bug 12716

This patch remove borrowernumber from the borrower list fields and
display the field list in the notes.

Test plan:
- verify that the list of fields is displayed on the right (Notes).
- verify the borrowernumber is not displayed anymore in the field list.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>
Confirmed that this patch removes borrowernumber from list of default
values, and reintroduces missing list of CSV columns in the Notes field.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12999: Untranslatable string on enhanced_content.pref
Bernardo Gonzalez Kriegel [Fri, 26 Sep 2014 00:35:29 +0000 (21:35 -0300)]
Bug 12999: Untranslatable string on enhanced_content.pref

This patch modifies LangInstaller.pm to catch strings
on syspref files that have no associated syspref

To test:
1) Update strings for your preffered language
2) Check that the string "you can only choose one source"
is not present on xx-YY-pref.po file

3) Apply the patch
4) Update strings again
5) Check the strig now appears [ and another one :) ]

Doing a diff before and after will show
 # Enhanced Content > All
 msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only
 choose one source of cover images from below, otherwise Koha will show
 the images from all sources selected."
 msgstr ""

 # Local Use
 msgid "local_use.pref## Nothing defined yet."
 msgstr ""

6) Translate the string
7) Install your language, check Administration > System preferences >
   Enhanced content > All
   (on your languge) and check the string is now translated

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt
Marc Véron [Sat, 20 Sep 2014 19:38:02 +0000 (21:38 +0200)]
Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt

If an item has no star ratings you get an error message in opac-error.log:
Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467.

To test:
In OPAC, search for a bilio that has no star ratings.
Check opac-error.log for message as above
Apply patch
Repeat search
Check opac-error.log again, there should be no more warnings

(Fixed mistake with brackets, see comment #2)

Signed-off-by: Magnus Enger <digitalutvikling@gmail.com>
Works as advertized. Looks like you have to be logged in to trigger
the error.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as advertised, passses xt/author/valid-templates.t

10 years agoBug 12538: Two SolR-related templates remaining
Jonathan Druart [Sat, 11 Oct 2014 22:30:13 +0000 (00:30 +0200)]
Bug 12538: Two SolR-related templates remaining

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12538: DBRev 3.17.00.027
Tomas Cohen Arazi [Sat, 11 Oct 2014 20:03:02 +0000 (17:03 -0300)]
Bug 12538: DBRev 3.17.00.027

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12538: FOLLOW UP Remove Moose from the list of dependencies
Chris Cormack [Tue, 23 Sep 2014 05:23:08 +0000 (17:23 +1200)]
Bug 12538: FOLLOW UP Remove Moose from the list of dependencies

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12538: Remove Solr without breaking anything else
Jonathan Druart [Mon, 7 Jul 2014 14:51:12 +0000 (16:51 +0200)]
Bug 12538: Remove Solr without breaking anything else

Since nobody is currently working on the zebra layer introduced by bug
8233, Solr won't never work.
Some code has been introduced in 3.10 to prove several search engines
can cohabit into Koha but no help/fund has been found to go ahead.
It is useless to keep this code and to maintain an ambiguous situation.

I think the indexes configuration page could be restore later if someone
else introduces a new search engine into Koha.

Test plan:
Look at the code introduced by bug 8233 and verify all is removed.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoFix of translation files as requested by RM
Bernardo Gonzalez Kriegel [Sat, 11 Oct 2014 14:42:43 +0000 (11:42 -0300)]
Fix of translation files as requested by RM

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7143: Adding Irma to the about page
Chris Cormack [Fri, 10 Oct 2014 19:57:47 +0000 (08:57 +1300)]
Bug 7143: Adding Irma to the about page

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7143: Fixed link to Athens County Koha Opac
Martin Renvoize [Thu, 4 Sep 2014 08:00:13 +0000 (08:00 +0000)]
Bug 7143: Fixed link to Athens County Koha Opac

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7143: Change the Kohala association link
Jonathan Druart [Thu, 4 Sep 2014 07:39:16 +0000 (09:39 +0200)]
Bug 7143: Change the Kohala association link

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7143 Adding a new developer to the history
Chris Cormack [Wed, 3 Sep 2014 22:19:47 +0000 (10:19 +1200)]
Bug 7143 Adding a new developer to the history

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12874: A DB field without a default mapping is set to a default value on editing
Jonathan Druart [Thu, 19 Jun 2014 13:18:23 +0000 (15:18 +0200)]
Bug 12874: A DB field without a default mapping is set to a default value on editing

If an item is edited and a field is not mapped to Koha, it is to 0 or
NULL (depending on the default value defined).

This patch adds a check on the mapping before editing the item. It there
is no mapping, the DB value is not erased.

Test plan:
1/ Edit an item and fill a value for a field
2/ Unmap this field
3/ Edit the item
4/ Verify that the value is not erased (using the MySQL CLI)

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12938 - strings.inc is missing a semicolon in var CIRCULATION_RENEW_FAILED =...
Olli-Antti Kivilahti [Wed, 17 Sep 2014 11:31:24 +0000 (14:31 +0300)]
Bug 12938 - strings.inc is missing a semicolon in var CIRCULATION_RENEW_FAILED = _("Renew failed:")

This doesn't appear to be affecting anything negatively, but the fix
makes it more correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12435: DBRev 3.17.00.026
Tomas Cohen Arazi [Sat, 11 Oct 2014 15:11:39 +0000 (12:11 -0300)]
Bug 12435: DBRev 3.17.00.026

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12435 - Update MARC21 frameworks to Update No. 18 (April 2014)
Bernardo Gonzalez Kriegel [Tue, 17 Jun 2014 11:28:17 +0000 (08:28 -0300)]
Bug 12435 - Update MARC21 frameworks to Update No. 18 (April 2014)

This patch updates MARC21 frameworks to Update No. 18 (April 2014)
Also updates values on database for MARC21 installs.

To test
1. Apply the patch
2. Run updatedatbase.pl, check that runs without error
3. Remove default framework, load again. Check that loads without
error.
4. Verify changes
Bibs
007/04 Sound recording -> q Quadraphonic, multichannel, or surround
347f -> Encoded bitrate
110/1,610/1,710/1,810/1 subfield c -> repeatable
Auth
110/1,410/1,510/1,710/1 subfield c -> repeatable

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Checked changes are according to documentation from LOC and
consistent between sample files and updatedatabase.pl.
No problems found, all English frameworks were updated.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 13051: And remember, usernames are not case sensitive
Marcel de Rooy [Thu, 9 Oct 2014 12:32:59 +0000 (14:32 +0200)]
Bug 13051: And remember, usernames are not case sensitive

opac-auth contains the following statement:
You entered an incorrect username or password. Please try again! And
remember, usernames and passwords are case sensitive.

Obviously, this is not completely true. The username can be entered in
lowercase, uppercase, any mixed case.

This patch simply adjusts this string.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12740: Make the error message translatable
Jonathan Druart [Mon, 22 Sep 2014 07:55:44 +0000 (09:55 +0200)]
Bug 12740: Make the error message translatable

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12740 - Data Validation followup
Mark Tompsett [Sat, 20 Sep 2014 12:01:36 +0000 (08:01 -0400)]
Bug 12740 - Data Validation followup

Added server-side validation and feedback to Koha news.

TEST PLAN
---------
1) Log in to staff client as someone who can add news
2) Paste a variation of the ugly following URL into your
   address bar:

https://demo.library-admin.kohasystem.ca/cgi-bin/koha/tools/koha-news.pl?op=add&lang=&branch=&title=&from=&to=&number=&new=

   -- A blank news item is added without warning!
3) Apply patch
4) Repeat step 2
   -- "ERROR: Required news title missing!" is displayed
      and no blank news is added
5) run koha qa test tools

Followed test plan, Error message appears as expected, qa test tool: OK
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12740 - It should not be possible to store empty news
Marc Véron [Sat, 13 Sep 2014 16:10:06 +0000 (18:10 +0200)]
Bug 12740 - It should not be possible to store empty news

This patch marks the title field as 'required' and it is not
longer possible to store a news without having at least a title.

To test:
Got to Tools->News
Create news or edit existing news
Field "Title" should have a red label and should be marked as "required"
It should not be possible to save with empty field "Title"

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Only keeps the user from doing it.
      Fails to handle the fake the url call case.
https://demo.library-admin.kohasystem.ca/cgi-bin/koha/tools/koha-news.pl?op=add&lang=&branch=&title=&from=&to=&number=&new=

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7372: (follow-up) remove debug message
Jonathan Druart [Thu, 9 Oct 2014 13:10:07 +0000 (15:10 +0200)]
Bug 7372: (follow-up) remove debug message

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Only removes debugging leftover. In french :-D

10 years agoBug 12985: All basketgroups should be listed
Jonathan Druart [Wed, 24 Sep 2014 13:50:49 +0000 (15:50 +0200)]
Bug 12985: All basketgroups should be listed

Only 20 first are listed, others are hidden.

Test plan:
- Create at least 21 basketgroups
- verify you can see it on the "open" tab
- close all of them
- verify you can see it on the "close" tab

There is no restriction to hide datables functions here.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12755 - MARC Preview doesn't always display in managed MARC record
Owen Leonard [Tue, 23 Sep 2014 16:24:34 +0000 (12:24 -0400)]
Bug 12755 - MARC Preview doesn't always display in managed MARC record

The MARC preview feature seems to have been broken by Bug 11570 -
Upgrade jQueryUI to the latest version. When that patch was being
developed there were no existing cases where the jQueryUI dialog feature
was used, so the patch omitted it.

Rather than update the build of jQueryUI to include the dialog feature
I'm submitting a patch which uses a Bootstrap modal instead. This keeps
the jQueryUI library smaller and avoids an unnecessary duplication of JS
functionality. It also helps keep our modals consistent.

The implementation uses progressive enhancement principles to improve
click handling: Real links in the table, so that the preview link can be
opened in a new tab if the user chooses; Event handling in the
JavaScript instead of the markup ( $(selector).on(click... instead of <a
onclick=...).

To test, apply the patch and add or view a batch of staged MARC records
(Tools -> Staged MARC management). In the list of titles (the "Citation"
column) click any link and confirm that the MARC preview loads
correctly. Confirm that previews work correctly on any page and after
re-sorting.

Confirm also that the modal window flexibly handles different browser
window sizes.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 9967 - include $branch_limit in the cache key
Robin Sheat [Mon, 2 Jun 2014 22:41:46 +0000 (10:41 +1200)]
Bug 9967 - include $branch_limit in the cache key

Make the caching more correct. Also removes a warn that got left behind.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 9967 - Cache authorised value requests properly
Robin Sheat [Wed, 9 Apr 2014 03:50:37 +0000 (15:50 +1200)]
Bug 9967 - Cache authorised value requests properly

Authorised values are now cached using the proper Koha::Cache mechanism,
rather than a simple internal cache. Memoize has been removed because it
didn't really work like we needed it to.

Test plan:
 * running a persistent environment:
 * load the edit item screen
 * refresh several times to ensure any process-based caches are filled
 * add a new LOC authorised value as fast as possible (prepare it on
   another tab.)
 * refresh the edit item page
 * note that the new LOC value may or may not be showing in the
   "shelving location"
 * if more than 5 seconds have passed since saving it, it must now show
   up.
 * refresh a few times to ensure that it's showing on all processes.

Note:
 * This patch depends on the caching changes of 9967.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12937 [Follow-up] Deleting suggestions should ask for a confirmation
Owen Leonard [Wed, 17 Sep 2014 12:31:27 +0000 (08:31 -0400)]
Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation

This minor follow-up revises the language a bit: Adding missing question
marks and using the more standard prompt "Please select at least one..."

To test, follow the previous test plan and confirm that the prompts are
improved:

- go on the suggestion management page
- don't select any suggestion and try to delete (check the checkbox and
  submit the form). Verify that you get an alert.
- select 1 suggestion and delete it, verify you get a confirmation
  message
- select 1+ suggestions and delete it, verify you get a confirmation
  message

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12937: Deleting suggestions should ask for a confirmation
Jonathan Druart [Wed, 17 Sep 2014 11:11:00 +0000 (13:11 +0200)]
Bug 12937: Deleting suggestions should ask for a confirmation

On the suggestion management page, the librarian can choose to delete
suggestions but no confirmation is needed.
This could produce unexpected lost of data.

Test plan:
- go on the suggestion management page
- don't select any suggestion and try to delete (check the checkbox and submit the form).
  Verify that you get an alert.
- select 1 suggestion and delete it, verify you get a confirmation
  message
- select 1+ suggestions and delete it, verify you get a confirmation
  message

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12876: (followup) remove useless diags
Tomas Cohen Arazi [Wed, 24 Sep 2014 00:07:08 +0000 (21:07 -0300)]
Bug 12876: (followup) remove useless diags

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12876: Improve unit tests for CanReserveBeCanceledFromOpac
Jonathan Druart [Fri, 5 Sep 2014 15:40:05 +0000 (17:40 +0200)]
Bug 12876: Improve unit tests for CanReserveBeCanceledFromOpac

This patch fix the subroutine name and add a restriction on the
arguments: both argument are mandatory!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12876 - Reserve in waiting/transfer status may be cancelled by user
Rafal Kopaczka [Fri, 5 Sep 2014 12:50:15 +0000 (14:50 +0200)]
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user

User may cancel his own reservation at waiting or in transit status
through calling opac-modrequest.pl. Cancel button is disabled in
interface but possibility to cancel should be checked also in
opac-moderequest.pl, before calling CancelReserve().
Similar situation is with opac-modrequest-suspend.pl

This patch provides new soubroutine to chceck if user can cancel given
reserve. It's possible only when he's owner of hold and hold isn't in
transfer or waiting status.

Additionaly there are new test for this function in Reserves.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests, QA script and new tests.
Works as described, tested with:
.../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12873 - Reserve can be cancelled by any logged in user
Rafal Kopaczka [Thu, 4 Sep 2014 14:40:33 +0000 (16:40 +0200)]
Bug 12873 - Reserve can be cancelled by any logged in user

It is possible to cancel reservations through simply running opac-modreserve.pl with existing reserve_id number. This may provide remove even all reservations from system. The only limitation is that user have to be logged in. Simplest solution is to check whether reserve belongs to user or not.

Test plan:
1. Create reserves by 2 different users, and get their ID's
2. Before patch, hold may by cancelled by anyone who run site:
http://example.com/cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX
3. After patch hold may by cancelled only by user whose reserve is.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch
Marc Véron [Fri, 25 Jul 2014 21:57:54 +0000 (23:57 +0200)]
Bug 12162 - Add class="branchcode" to body tag to make OPAC CSS-styleable per branch

This patch adds a branch sepecific class to all OPAC pages.

Example:
If not logged in, opac-main.pl displays:
<body ID="opac-main" class="branch-default" >
If logged in at branch FFL, it displays:
<body ID="opac-main" class="branch-FFL" >

If you log in, opac-user.pl should display
<body ID="opac-user" class="branch-FFL scrollto" >

To test:
1)
Apply patch.

2)
Add to syspref OPACUserCSS something highly visible, e.g. for branch FFL:
.branch-FFL {
background-color: yellow;
border: 10px solid red;
}

3)
Go to OPAC and login in with a user with home branch FFL

4)
Verify that colors change as appropriate.

5)
Log out. Verify that colors display as before or as defined in class branch-default in OPACUserCSS

6)
Display patch in patch diff view, verify that ids and classes in body tag are consistent with params bodyid and bodyclass in INCLUDE line

7)
Search for regressions

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11672: (followup) warnings tested
Tomas Cohen Arazi [Wed, 27 Aug 2014 13:11:28 +0000 (10:11 -0300)]
Bug 11672: (followup) warnings tested

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11672: Untranslatable dropdown on Guided Reports and dictionary
Tomas Cohen Arazi [Sun, 24 Aug 2014 05:11:50 +0000 (02:11 -0300)]
Bug 11672: Untranslatable dropdown on Guided Reports and dictionary

This patch removes hardcoded descriptions and sets them in the templates
using the variable content as id.

To test, create a new guided report and verify the 'module to report on' dropdown
shows as usual [1]. Functionality shouldn't get changed.

The patch also changes the dictionary pages where 'area' should be displayed/selectable
with the same strings as the guided reports. Try all the possible disctionary pages.

The last page when creating a dictionary now shows the 'area description' instead of the
code. The same happens to the dictionary list once you have dictionaries saved.

[1] The following texts get changed:
    Catalogue -> Catalog
    Acquisition -> Acquisitions

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11672: (regression test) get_report_areas gets tested
Tomas Cohen Arazi [Sun, 24 Aug 2014 05:21:52 +0000 (02:21 -0300)]
Bug 11672: (regression test) get_report_areas gets tested

This patch introduces a unit test for the new get_report_areas functionality.

To try it, run
  $ prove t/db_dependent/Reports_Guided.t

It is expected to have 16 tests defined, and to fail the introduced one

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11633 Return Correct status if patron blocked by fines
Colin Campbell [Thu, 17 Apr 2014 15:07:20 +0000 (16:07 +0100)]
Bug 11633 Return Correct status if patron blocked by fines

If the patron has amassed charges that block borrowing, but we
allow staff override the information that the patron cannot
issue should be included the patron information response

This patch sets the appropriate status fields in the patron object

It restores the fee_limit member to the patron object
and calls a local subroutine to set it.

This could be done more elegantly but that would require more
major refactoring of the rather messy initializer code
in ILS::Patron

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11633 : Block Issue if fines require staff override
Colin Campbell [Thu, 17 Apr 2014 14:55:03 +0000 (15:55 +0100)]
Bug 11633 : Block Issue if fines require staff override

If a patrons fines exceed noissuescharge and we allow
staff to allow issue at their discretion via an override
the SIP process allowed charges to go ahead.
This patch closes the loophole which allowed self issue
to subvert the usual library loan policy

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 7372: (follow-up) does execute this DB entry twice
Jonathan Druart [Thu, 11 Sep 2014 13:22:44 +0000 (15:22 +0200)]
Bug 7372: (follow-up) does execute this DB entry twice

Since this enh has been backported on 3.14, this patch should be applied
on 3.16 and master branch in order to update the updatedb entry.
It should not be executed twice otherwise the process is stuck on this
entry.

http://irc.koha-community.org/koha/2014-09-11#i_1567078
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12963: Columns misplaced in moremember.tt
Rafal Kopaczka [Fri, 19 Sep 2014 12:27:04 +0000 (14:27 +0200)]
Bug 12963: Columns misplaced in moremember.tt

After applying Bug 12899, in moremember page, checkouts table has
misplaced columns.

Test plan:
1. Check out title for a user. Columns in Detail page at checkout tab
are misplaced; there's no Due date column.
2. Aplly patch, everything shuld look fine now.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
My bad! Thanks for catching this.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12953: FIX NewOrder test
Jonathan Druart [Thu, 18 Sep 2014 07:42:02 +0000 (09:42 +0200)]
Bug 12953: FIX NewOrder test

The patch for bug 12827 has been written some days before bug 10402. One
occurrence of NewOrder has not been modified.

Test plan:
  prove t/db_dependent/Letters.t

should return green.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 8868: Follow-up: Update boostrap documentation page
Katrin Fischer [Mon, 18 Aug 2014 09:02:01 +0000 (11:02 +0200)]
Bug 8868: Follow-up: Update boostrap documentation page

Updates the bootstrap documentation page for CancelHold.

10 years agoBug 8868: ILS-DI: CancelHold needs to take a reserve_id
Julian Maurice [Wed, 3 Oct 2012 11:23:04 +0000 (13:23 +0200)]
Bug 8868: ILS-DI: CancelHold needs to take a reserve_id

CancelHold takes two parameters: patron_id and item_id.
If item_id is considered as an itemnumber, holds on title can't be
canceled.
If item_id is considered as a biblionumber, all holds on this
biblionumber (for a borrower) will be canceled.

So CancelHold have to consider item_id as a reserve_id.

- Added subroutine C4::Reserves::GetReserve
- C4::ILSDI::Services::GetRecords now returns the reserve_id
- Fix the text in the ilsdi.pl?service=Describe&verb=CancelHold page
- Unit tests for CancelReserved and GetReserve
- Do not delete row in reserves table if insert in old_reserves fails

Signed-off-by: Leila and Sonia <koha.aixmarseille@gmail.com>
Signed-off-by: Benjamin Rokseth <bensinober@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signing off, while noting a style issue in the patch review

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.
Placed and cancelled a hold using ILS-DI successfully.
Adding a follow-up to also update the ils-di documentation
page in the bootstrap theme.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
EDIT: I removed the changes it did to the prog theme.

10 years agoBug 12405 - Search links on callnumber fails on intranet results page
Fridolin Somers [Wed, 11 Jun 2014 10:25:19 +0000 (12:25 +0200)]
Bug 12405 - Search links on callnumber fails on intranet results page

On intranet results page, the callnumber of items is a search like :
/cgi-bin/koha/catalogue/search.pl?idx=callnum&amp;q=[% result.itemcallnumber |url %]

The callnumber should be URI-escaped to avoid special URI characters like & , ? ...
If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes.

This patch adds this to catalogue/results.pl and catalogue/shelves.pl :
- uri TT filter instead of url
- adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes

Test plan :
- Edit an item callnumber with : & ABC 123
- Index zebraqueue
- Perform a search returning this item
- Click on the callnumber
=> Without this patch you get no result, because URL parameters are : idx=callnum&q=& ABC 123
=> With this patch you get results
- Set syspref QueryWeightFields off (because this is no bug if on)
- Edit an item callnumber with : AB(C) AND OR
- Index zebraqueue
- Perform a search returning this item
- Click on the callnumber
=> Without this patch you get no result, because the search contains CCL words "OR" and "AND"
=> With this patch you get results

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Tested all with and without queryweightfields -
all searches from clicked call numbers for given callnumbers fail without the patch, all are successful with the patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described - no problems found.
Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12763 [QA Followup] - Remove tabs and trailing space
Kyle M Hall [Fri, 15 Aug 2014 13:07:07 +0000 (09:07 -0400)]
Bug 12763 [QA Followup] - Remove tabs and trailing space

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12763: Add more information for users to OPAC Error 404 page
Marc Véron [Fri, 1 Aug 2014 18:30:04 +0000 (20:30 +0200)]
Bug 12763: Add more information for users to OPAC Error 404 page

This patch adds more information to the OPAC 404 error page to make it more user friendly.

To test:

- Apply patch
- Is the information clearly understandable and does it contain all necessary information?
- Native speakers: Is the text correct?
- Non native speakers: Is the text easy to translate?
- Is the HTML correct?

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 4927 - OPAC advanced search has two call number entries; remove one?
Marc Véron [Mon, 21 Jul 2014 18:52:41 +0000 (20:52 +0200)]
Bug 4927 - OPAC advanced search has two call number entries; remove one?

This patch removes the second Call number entry in OPAC Advanced search with Advanced option (for bootstrap).

To test:
- Go to OPAC, Advanced search, enable Advaced options
- In dropdowns you see two entries "Call number"
- Apply patch
- Verify that the second "Call number" has disappeared (below ISSN)

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template change only - no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12609: Add some unit tests for C4::Ratings
Jonathan Druart [Fri, 29 Aug 2014 14:41:29 +0000 (16:41 +0200)]
Bug 12609: Add some unit tests for C4::Ratings

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class
Kyle M Hall [Fri, 18 Jul 2014 14:42:03 +0000 (10:42 -0400)]
Bug 12609 - Replace use of DBI in C4::Ratings with DBIx::Class

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Ratings.t
3) Note all unit tests pass

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Also tested:
- Adding a rating
- Rating displayed on detail
- Rating displayed on results
- Modifying a rating
- Change displayed correctly on detail and results

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12890 - Improve title and breadcrumbs when editing saved SQL report
Owen Leonard [Mon, 8 Sep 2014 18:16:14 +0000 (14:16 -0400)]
Bug 12890 - Improve title and breadcrumbs when editing saved SQL report

When editing an existing SQL report the page title and breadcrumbs are
incomplete:

Home > Reports > Guided reports wizard >

This patch corrects this.

To test, apply the patch and edit an existing SQL report. The page title
and breadcrumbs should be more complete:

Home > Reports > Guided reports wizard > Saved reports > Edit SQL report

Patch behves as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)
Jacek Ablewicz [Sat, 2 Aug 2014 08:13:16 +0000 (10:13 +0200)]
Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)

In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template,
there is a surplus closing </div> in line 336 (= line 332, in case
Bug 12521 is applied first):

   336: </div> <!-- / .span4 -->

which causes some minor layout problems for this page - i.e.: page
footer ("Powered by Koha" + custom footer set up in system prefrences -
if any) is "glued" to the bottom (to the language selection bar);
unless Bug 12521 is applied first, this affects the placement of the
2nd search bar as well.

To reproduce:

1/ go to the OPAC advanced search page
2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the
result
3/ no need for step 2/ (zooming out) when using a display with
(relatively) high vertical resolution; also, this particullar problem
gets more apparent/more noticeable with MARC21/USMASRC "subtype"
options being hidden in the OPAC advanced search (Bug 9043).

To test:

1/ ensure that Bug 12521 is applied first/already applied
2/ apply patch
3/ confirm that this issue is no longer reroductible

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
On top of 12521, don't know exactly what to reproduce, but
surplus '</div>' is real (33 open, 34 close).
Everything looks correct, no koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12521 - Change layout a bit of the opac advanced search
Liz Rea [Wed, 2 Jul 2014 22:09:22 +0000 (10:09 +1200)]
Bug 12521 - Change layout a bit of the opac advanced search

To test:

Load up the advanced search and make sure it displays properly, with all of the elements within the main div, and only one container-fluid.

Patch behaves as expected. Advanced search looks much better now.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked visually and with HTML validator.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server admin...
Marc Véron [Wed, 10 Sep 2014 14:10:21 +0000 (16:10 +0200)]
Bug 12882 - Translations: Resolve ambiguity for word "checked" in Z39.50 server administration

This patch resolves the ambiguity of the word "Checked" for Z39.50
server administration.

To test:
Apply patch
In staff client, go to Home:Administration:Z39.50/SRU servers
Result: Column heading of 6th column should show "Preselected" (instead
of "Checked")

Edit or create new server for Z39.50 and SRU
Result: Checkbox underneath "Password" should have label "Preselected
(searched by default):"

Click "Help" at top right of screen
Result: Wording changed for selecting targets as default.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12863 [CSS follow-up] News in OPAC: HTML broken with nested p tags and multiple...
Owen Leonard [Fri, 5 Sep 2014 13:04:41 +0000 (09:04 -0400)]
Bug 12863 [CSS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table

This patch contains the revised and compiled CSS which will style the
OPAC's new news markup to match the previous version.

To test, apply the patch and clear your browser cache if necessary. View
news in the OPAC and confirm that it is styled like it was before the
patch making markup changes.

CSS patch behaves as expected. Thanks to Owen for adding this.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12863 [LESS follow-up] News in OPAC: HTML broken with nested p tags and multiple...
Owen Leonard [Fri, 5 Sep 2014 13:02:28 +0000 (09:02 -0400)]
Bug 12863 [LESS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table

This follow-up modifies the LESS file to add style to the new markup to
match the previous markup. A subsequent patch will include the revised
and compiled CSS.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same...
Marc Véron [Wed, 3 Sep 2014 10:10:26 +0000 (12:10 +0200)]
Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table

This patch fixes broken HTML in OPAC news by replacing table display
with divs.

To test:

Create multiple news for OPAC
Validate with HTML validator or check source code
Result:
Error with nested p tags
Table header thead is repeated for every news (not allowed)
Bonus testing: Let a screen reader like NVDA read the news and try to
understand it with closed eyes.

Apply patch
Result:
No more HTML errors in news
Screen reader reads news properly

To style you can use classes newscontainer, newsitem, newsheader,
newsbody and newsfooter.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12728: DBRev 3.17.00.025
Tomas Cohen Arazi [Thu, 18 Sep 2014 00:33:49 +0000 (21:33 -0300)]
Bug 12728: DBRev 3.17.00.025

10 years agoBug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql
Marcel de Rooy [Thu, 21 Aug 2014 11:06:20 +0000 (13:06 +0200)]
Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql

This patch adds a dbrev.
If people installed Koha after the initial dbrev (3.09.00.015), an install
with sysprefs.sql did not add the pref. So they still could not have it.

Test plan:
If you have the pref, running an database update should not do anything.
If you do not have the pref (delete it via mysql), it should be added.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12728: Add StatisticsFields to sysprefs.sql
Marcel de Rooy [Thu, 7 Aug 2014 12:16:24 +0000 (14:16 +0200)]
Bug 12728: Add StatisticsFields to sysprefs.sql

Bug 7955: [Statistics tab for Patron checkouts] introduced the pref
StatisticsFields but did not add it to the sql install file.

Test plan:
Run webinstaller or mysql ... < sysprefs.sql
Verify that the new pref is in your systempreferences table.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Run webinstall, new syspref loaded.
No koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12827: NewOrder needs more unit tests
Jonathan Druart [Tue, 26 Aug 2014 14:43:49 +0000 (16:43 +0200)]
Bug 12827: NewOrder needs more unit tests

NewOrder should be more tested!

This patch moves the existing unit tests into a new file and adds some
unit tests.

Note that there is no DB field aqorders.subscription, so the test in
NewOrder can be removed.

Test plan:
  prove t/db_dependent/Acquisition/NewOrder.t
and
  prove t/db_dependent/Acquisition.t
should return green.

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12827: NewOrder should not return basketno
Jonathan Druart [Tue, 26 Aug 2014 14:06:10 +0000 (16:06 +0200)]
Bug 12827: NewOrder should not return basketno

Since the basketno parameter is needed to insert an order, it is useless
to return it.

This patch changes the prototype for the C4::Acquisition::NewOrder
subroutine. The return value is now a scalar containing the ordernumber
created.

Test plan:
Verify there is no regression on an acquisition workflow:
1/ Create an order with several items
2/ Modify the order
3/ Receive some items
4/ Cancel the receipt
4/ Receive some items
5/ Receive all remaining items
6/ Cancel the receipt

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12891: NewOrder does not return ordernumber if ordernumber is defined
Jonathan Druart [Mon, 8 Sep 2014 18:25:27 +0000 (20:25 +0200)]
Bug 12891: NewOrder does not return ordernumber if ordernumber is defined

The behavior is quite weird, but
  $schema->resultset('Table')->create($data)->id
does not return the id inserted if $data contains the key.

To be more clear, in this case
  $schema->resultset('Aqorder')->create($new_order)->id
returns an empty string because $new_order->{ordernumber} is an empty
string!

This was not caught by the unit tests, I added one.

Test plan:
- AcqCreateItem set to ordering
- Create an order with items and verify items are correctly linked to the
  order.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed that without the patch the created item is not linked to the
order (entry in aqorders_items). With the patch, it works as expected.
Passes tests and Koha QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Update DBIx
Tomas Cohen Arazi [Thu, 18 Sep 2014 00:10:20 +0000 (21:10 -0300)]
Bug 11577: Update DBIx

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10883 - AllowHoldDateInFuture can let a patron jump to the top of the holds list
Kyle M Hall [Wed, 27 Aug 2014 13:05:12 +0000 (09:05 -0400)]
Bug 10883 - AllowHoldDateInFuture can let a patron jump to the top of the holds list

If a patron is allowed to add a future date for the hold using the
"Hold starts on date" field, that patron can put a date in that is
in the *past* which will cause them to move to the top of the holds
queue ( assuming they make the past date far enough back that it is
earlier than all the other hold dates ).

Test Plan:
1) Enable future holds
2) Note you can use dates in the past for "hold starts on date"
3) Note you can use dates in the past for "hold expires on date"
4) Apply this patch
5) Refresh the page
6) Note you can no longer use dates in the past for those fields

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changed subject: OpacAllowHoldDateInFuture to AllowHoldDateInFuture
as this fix applies to staff.
Works as described, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: DBRev 3.17.00.024
Tomas Cohen Arazi [Wed, 17 Sep 2014 23:08:14 +0000 (20:08 -0300)]
Bug 11577: DBRev 3.17.00.024

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577 : Fixing a tiny copy/paste issue
Martin Renvoize [Wed, 27 Aug 2014 17:32:38 +0000 (17:32 +0000)]
Bug 11577 : Fixing a tiny copy/paste issue

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577 : Fixing a tiny typo
Chris Cormack [Tue, 29 Jul 2014 05:58:57 +0000 (17:58 +1200)]
Bug 11577 : Fixing a tiny typo

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Add Hochschule für Gesundheit to contributing institutions
Holger Meißner [Thu, 22 May 2014 08:21:09 +0000 (10:21 +0200)]
Bug 11577: Add Hochschule für Gesundheit to contributing institutions

Automatic renewal is the second feature sponsored by the hsg.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Unit tests
Holger Meißner [Mon, 19 May 2014 12:00:48 +0000 (14:00 +0200)]
Bug 11577: Unit tests

This patch fixes two unit tests that broke because of the new feature.
Also adds some new test cases.

To test:

1) prove t/db_dependent/Circulation.t
2) prove t/db_dependent/Circulation_Issuingrule.t

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Add an automatic renewal cronjob
Holger Meißner [Fri, 16 May 2014 11:14:32 +0000 (13:14 +0200)]
Bug 11577: Add an automatic renewal cronjob

This patch adds a new cron script automatic_renewals.pl and a new
entry in crontab.example.

To test:

1) You need a few issues, some with automatic renewal and some without.
2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl
   those issues are renewed that meet all of the following criteria:
   - automatic renewal has been scheduled either by issuing rule or by
     checkbox on the checkout page
   - the number of allowed renewals isn't exceeded
   - renewal isn't premature (No renewal before)
3) Confirm that all other issues are not affected.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: OPAC bootstrap theme changes
Holger Meißner [Thu, 15 May 2014 14:48:02 +0000 (16:48 +0200)]
Bug 11577: OPAC bootstrap theme changes

This patch makes opac-user.pl and the bootstrap version of opac-user.tt
handle the new renewal errors "auto_renew" and "auto_too_soon".

To test:

1) Set global syspref "opacthemes" to bootstrap.
2) Set global syspref "OpacRenewalAllowed" to Allow.
3) Test the same things as in previous patch, this time for the OPAC
   summary page.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Expand description of AllowRenewalLimitOverride
Holger Meißner [Wed, 21 May 2014 13:45:35 +0000 (15:45 +0200)]
Bug 11577: Expand description of AllowRenewalLimitOverride

With the introduction of the new automatic renewal feature global syspref
AllowRenewalLimitOverride is expanded in meaning. It now gives the option
to override blocks if:

- the number of allowed renewals is exceeded
- the renewal is premature (No renewal before)
- the item is scheduled for automatic renewal
- the renewal is premature and the item is scheduled for automatic renewal

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page
Holger Meißner [Wed, 21 May 2014 13:15:11 +0000 (15:15 +0200)]
Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page

This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon'
to the renewal interface.

To test:

1) Issue two items:
   - one with automatic renewal and no value for "No renewal before"
   - another with automatic renewal and a value for "No renewal before"
2) Try to renew:
   Home > Circulation > Renew
3) Confirm there are error messages explaining that the items have been
   scheduled for automatic renewal and that one of the renewals is also
   premature.
4) If global syspref AllowRenewalLimitOverride is set to "Allow" you
   should be given the option to override.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Code and intranet template changes
Holger Meißner [Thu, 15 May 2014 14:43:00 +0000 (16:43 +0200)]
Bug 11577: Code and intranet template changes

This patch adds a checkbox for "Automatic renewal" to the checkout page.
CanBookBeRenewed is modified to include two new errors:
- auto_renew (renewal shouldn't be done manually)
- auto_too_soon (renewal is premature and shouldn't be done manually)

To test:

1) Add or edit an issuing rule with "Automatic renewal" and another
   one without it.
2) Issue at least three items:
   - automatic renewal by issuing rule
   - automatic renewal by Checkbox on the checkout page
   - no automatic renewal
3) Test the following steps for both:
   Home > Circulation > Checkouts
   Home > Patrons > Patron details
4) Confirm that issues with automatic renewal cannot be renewed manually,
   even if there are still renewals left and it's not too soon to renew.
5) Confirm that "Scheduled for automatic renewal" and the remaining
   renewals are displayed. If no renewals are left "Not renewable" should
   be displayed.
6) Confirm that issues without automatic renewal behave as usual.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Add "Automatic renewal" to the circulation and fine rules
Holger Meißner [Thu, 15 May 2014 14:30:39 +0000 (16:30 +0200)]
Bug 11577: Add "Automatic renewal" to the circulation and fine rules

This patch adds a column "Automatic renewal" to the circulation and
fine rules table.

To test:

1) Add or edit some issuing rules.
2) Confirm that "Automatic Renewal" is set to "No" by default and
   can be switched to "Yes".

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 11577: Add auto_renew flags to the database
Holger Meißner [Thu, 15 May 2014 14:18:36 +0000 (16:18 +0200)]
Bug 11577: Add auto_renew flags to the database

- issues.auto_renew
- old_issues.auto_renew
- issuingrules.auto_renew

Default value is zero.

To test:

1) Run installer/data/mysql/updatedatabase.pl
2) Create SQL reports like:
   SELECT * FROM issues LIMIT 0,1
3) Confirm that a column auto_renew was added to each of the three tables.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12879: Remove unnecesary diags from Holds.t
Tomas Cohen Arazi [Fri, 5 Sep 2014 15:41:20 +0000 (12:41 -0300)]
Bug 12879: Remove unnecesary diags from Holds.t

There are two unnecessary diag statements:
- Creating biblio instance for testing.
- Creating item instance for testing.

TEST PLAN
---------
1) prove t/db_dependent/Holds.t

t/db_dependent/Holds.t .. 1/38 # Creating biblio instance for testing.
Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181.
 # Creating item instance for testing.
Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181.
Use of uninitialized value in subroutine entry at /home/tcohen/git/koha-community-src/C4/Charset.pm line 181.
t/db_dependent/Holds.t .. ok
All tests successful.
Files=1, Tests=38,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.13 cusr  0.11 csys =  1.28 CPU)
Result: PASS

-- They are in the first and fourth lines of this sample output

2) apply patch
3) prove t/db_dependent/Holds.t

t/db_dependent/Holds.t .. 1/38 Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186.
Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186.
Use of uninitialized value in subroutine entry at /home/mtompset/kohaclone/C4/Charset.pm line 186.
t/db_dependent/Holds.t .. ok
All tests successful.
Files=1, Tests=38,  1 wallclock secs ( 0.01 usr  0.00 sys +  0.78 cusr  0.09 csys =  0.88 CPU)
Result: PASS

-- They are no longer in the first and fourth lines of this sample output

4) run koha QA test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12899: Row grouping in checkouts table is alphabetical and depends on translation
Owen Leonard [Wed, 10 Sep 2014 12:56:24 +0000 (08:56 -0400)]
Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation

The sort order of the "today's checkouts" and "previous checkouts" row
groupings depends on the label, so in English "today's checkouts" comes
first. However, in other languages the reverse alphabetical order is
incorrect resulting in "previous checkouts" coming first.

This patch adds a dummy column with numeric data on which the sorting
can be done. This should make it translation-agnostic.

To test, apply the patch and install or update a translation which will
demostrate the problem (sv-SE for instance).

- Clear your browser cache and switch to the English templates.
- Check out some items to a patron who has checkouts from a previous
  day.
- Confirm that the sorting of the "today's checkouts" and "previous
  checkouts" row groups is correct.
- Switch to the new/updated translation and reload the circulation page
  for that patron. Confirm that the sort remains correct.
- Confirm that the checkouts table looks correct and that other features
  (sorting, checkboxes) still work correctly.

Revision: Corrected the table footer include to correct the colspan
error causing column misalignment.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12811 - Patron 'Details' and 'Check out' pages not working for staff users withou...
Jacek Ablewicz [Sat, 23 Aug 2014 14:36:21 +0000 (16:36 +0200)]
Bug 12811 - Patron 'Details' and 'Check out' pages not working for staff users without renewal override permissions

In case when the staff user doesn't have (circulate) ->
(override_renewals) permission granted, this code part

   var AllowRenewalLimitOverride = [%
CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %];

in circ/circulation.tt and members/moremember.tt leads to javascript
error, because TT statement evaluates to empty string.

To reproduce:

- set AllowRenewalLimitOverride syspref to "Don't allow" (this step is
  possibly redundant / not quite relevant),
- for testing purposes, log in as some (sample) staff user whitch does
  not have permission granted for "(override_renewals) Override blocked
  renewals",
- have a look at some patron accounts (preferably, ones with 1+
  check-out), observe that page layout is incorrect in "Check Out" and
  "Details" tab.

To test:

- apply patch,
- retest and ensure that this issue is no longer reproductible,
- make sure that there are no regressions of any kinds regarding renewal
  override permission for staff users (i.e, that it still works like
  intended).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes QA script and tests.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12729 - Overdue items won't show as overdue in red in circulation
Dobrica Pavlinusic [Thu, 4 Sep 2014 13:16:57 +0000 (15:16 +0200)]
Bug 12729 - Overdue items won't show as overdue in red in circulation

It seems that Firefox date parser doesn't like our dates which are
formatted in ISO format like "2014-08-06 00:00:00". This results in
missing red color in overdue dates.

So intead of munching different date formats and JavaScript (and having
to support different browers) this patch moves check for overdue dates
back to mysql and just transfers boolean value to JavaScript so it can
show correct class for date_due.

Test scenario:
1. find borrower with overdue checkouts
2. verify that all dates are black (and are in ISO format)
3. apply this patch
4. reload page and verify that overdue dates turned red

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with different due dates (hourly and not) and different date formats.
Passes tests and QA script.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12859 - Patron import tool doesn't import extened attributes values any longer
Jacek Ablewicz [Tue, 2 Sep 2014 09:46:06 +0000 (11:46 +0200)]
Bug 12859 - Patron import tool doesn't import extened attributes values any longer

To reproduce:

1/ define/set up extended pattron attribute in administration module,
2/ using "Tools -> Import patrons", try to import some sample patron
record[s], having some arbitrary (non-empty) value assigned in
'pattron_attributes' CSV column for attribute defined in step 1/,
3/ observe that extended attribute defined in step 1/ was not imported
(not added to the database), without any warnings.

This patch restores a small code chunk which went AWOL somewhere around
commit b4158f2d2485c9e57bd7f14362b210732bef9d35.

To test:

1/ apply patch & retest,
3/ ensure that this issue is no longer reproductible, and there are no
apparent regressions of any kind,
4/ make sure that the ability to specify default value for extended
attributes added in bug Bug 12716 is still working as intended
(= follow up the test plan for bug 12716).

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>
Patch fixes import of extended patron attributes.
Step 1-3 in test plan confirmed.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12918: fix failing test case
Robin Sheat [Mon, 15 Sep 2014 02:08:03 +0000 (14:08 +1200)]
Bug 12918: fix failing test case

A bug in a test case causes test case failure. It also required a
database, so I'm moving it out of the way.

Test plan:
1) prove -v t/db_dependent/Templates.t
   -- bombs!
2) apply patch
3) prove -v t/db_dependent/Templates.t
   -- works!

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12870 - require a higher version of Test::Simple
Robin Sheat [Thu, 4 Sep 2014 05:02:21 +0000 (17:02 +1200)]
Bug 12870 - require a higher version of Test::Simple

New test cases won't build with the version of this in squeeze.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12898 - Z39.50 title search doesn't work with multiple words
Dobrica Pavlinusic [Wed, 10 Sep 2014 11:27:20 +0000 (13:27 +0200)]
Bug 12898 - Z39.50 title search doesn't work with multiple words

This fixes regression introduced by Bug 6536 so that multiple
words in title search will work.

Test scenario:

1. try z39.50 search with more than one word
2. verify that no results apper
3. apply patch and re-run search
4. verify that there are results

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12898: (regression test) test terms inside double quotes
Tomas Cohen Arazi [Sun, 14 Sep 2014 04:55:33 +0000 (01:55 -0300)]
Bug 12898: (regression test) test terms inside double quotes

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10226: Add unit tests for GetReservesFromItemnumber
Jonathan Druart [Wed, 10 Sep 2014 14:21:09 +0000 (16:21 +0200)]
Bug 10226: Add unit tests for GetReservesFromItemnumber

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10226 - suspended holds still show not available
Kyle M Hall [Wed, 27 Aug 2014 12:29:05 +0000 (08:29 -0400)]
Bug 10226 - suspended holds still show not available

If you suspend a hold, the item does not show Available.  It still shows
the person next in line, who isn't eligible for the hold yet because of
the suspension.  This is not the case for a delayed hold, where you
originally place the hold and tell it not to start until a future date.
If you do that, it shows as Available.  This is confusing and
inconsistent.

Test Plan:
1) Create an item level suspended hold for a record with no other holds
2) Note in the record details that the hold shows an item level hold
3) Apply this patch
4) Refresh the record details page, note the item is "Available"
5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12574 - BiblioDefaultView doesn't affect XSLT results view
Owen Leonard [Mon, 14 Jul 2014 16:49:27 +0000 (12:49 -0400)]
Bug 12574 - BiblioDefaultView doesn't affect XSLT results view

The OPAC's XSLT results view does not respect the choice set in the
BiblioDefaultView system preference. This patch adds a check of the
preference to the OPAC's results view for MARC21.

To test you must have the OPAC configured to use the XSLT view for
search results. Perform any search and test the link to a title's detail
page. Switching the values of the BiblioDefaultView should be correctly
reflected in the search results links.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described for XSLT view in OPAC.

Notes:
- maybe we should change the pref text from 'simple form' to 'normal view'.
- the patch doesn't include changes to the title link generated from an 880
  field - so those links will still lead to the wrong view.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 10571 - IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT
Owen Leonard [Mon, 14 Jul 2014 17:07:42 +0000 (13:07 -0400)]
Bug 10571 - IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT

The staff client's XSLT results view does not respect the choice set in
the IntranetBiblioDefaultView system preference. This patch adds a check
of the preference to the staff client's results view for MARC21.

To test you must have the staff client configured to use the XSLT view
for search results. Perform any search and test the link to a title's
detail page. Switching the value of the IntranetBiblioDefaultView
preference should be correctly reflected in the search results links.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no koha-qa errors.

Only for MARC21 :(

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12587: (qa followup) report name consistency
Tomas Cohen Arazi [Tue, 9 Sep 2014 13:47:02 +0000 (10:47 -0300)]
Bug 12587: (qa followup) report name consistency

Reports home should show the same report name (i.e. "Patrons with the most checkouts")
the report itself uses. It is chosen as it is more idiomatic.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12587 - Improve output of filter information on patrons with the most checkouts...
Owen Leonard [Wed, 16 Jul 2014 15:23:00 +0000 (11:23 -0400)]
Bug 12587 - Improve output of filter information on patrons with the most checkouts report

This patch makes some changes to the way filter information is displayed
after running the patrons with the most checkouts report. Before this
patch several untranslatable English strings would be displayed, and
library and item type codes would be shown instead of descriptions.

To test, go to Reports -> Patrons checking out the most. Enter values
for all the filter options:

- Checkout date from
- Checkout date to
- Checkin date from
- Checkin date to
- Library
- Item type
- Patron category

When you submit the form and view the results you should see your date
submissions formatted according to your selected dateformat system
preference. The library name and item type names should be shown instead
of codes.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Improves translatability of the filters output after running
the report and the readability of them (removing codes).

Note: it would be nice if the read-only would be removed from the date
fields, as forcing people to use the date widget is a known accessibility
issue.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12849 - fix URLs in sent lists
Robin Sheat [Fri, 29 Aug 2014 04:19:22 +0000 (16:19 +1200)]
Bug 12849 - fix URLs in sent lists

This brings back the http(s) to the URLs in sent lists.

Test plan:
* make a list
* send it to yourself
* see that the URLs aren't clickable
* apply the patch
* repeat, except now the URLs are better

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
By removing this bit of code, the code in Auth.pm is used
instead. The code there is not perfect, but the solution
works and both list and cart use the same code.

Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12557: DBRev 3.17.00.023
Tomas Cohen Arazi [Tue, 9 Sep 2014 13:11:44 +0000 (10:11 -0300)]
Bug 12557: DBRev 3.17.00.023

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
10 years agoBug 12557: Partially received - the change should affect the new order
Jonathan Druart [Thu, 21 Aug 2014 09:02:48 +0000 (11:02 +0200)]
Bug 12557: Partially received - the change should affect the new order

If the receipt in not on the whole order but only on a part of it, the
change should be done on the itemnumber linked to the "new order", the
one we are reverting.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>