From b5c8aad0f643b966f3701bc2da63c0bf9c54e4c3 Mon Sep 17 00:00:00 2001 From: Robin Sheat Date: Tue, 31 Jul 2012 13:22:48 +0200 Subject: [PATCH] Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. Signed-off-by: Jonathan Druart I replace "return undef" with just "return" to pass perlcritic Signed-off-by: Chris Cormack --- Koha/DateUtils.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 0b611113fd..b2c1df8c8a 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -95,7 +95,8 @@ s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/; $date_string = output_pref($dt, [$format] ); -Returns a string containing the time & date formatted as per the C4::Context setting +Returns a string containing the time & date formatted as per the C4::Context setting, +or C if C was provided. A second parameter allows overriding of the syspref value. This is for testing only In usage use the DateTime objects own methods for non standard formatting @@ -105,6 +106,9 @@ In usage use the DateTime objects own methods for non standard formatting sub output_pref { my $dt = shift; my $force_pref = shift; # if testing we want to override Context + + return unless defined $dt; + my $pref = defined $force_pref ? $force_pref : C4::Context->preference('dateformat'); given ($pref) { -- 2.39.5