]> git.koha-community.org Git - koha.git/commit
Bug 8246: Allow deleting record if no more items
authorJonathan Druart <jonathan.druart@biblibre.com>
Tue, 31 Mar 2015 14:32:33 +0000 (16:32 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 8 Apr 2015 14:10:28 +0000 (11:10 -0300)
commit2a8f84817fb4a487577c7e4238b8aede9d9b99d2
tree8d4bb3c17c8710b733d8d6a1e6b10cf0a7715908
parent80ffd8354bff15ef006da746ce516f6e9b497dc5
Bug 8246: Allow deleting record if no more items

The "Delete records if no items remain" was only available if the batch
did not contain "too many" items (see MaxItemsForBatch).
This limitation does not make any sense.

Test plan:
1/ Set MaxItemsForBatch=10
2/ Use the batch item deletion to delete 10+ items
3/ Confirm the checkbox "Delete records if no items remain" is displayed
4/ Check it
5/ Launch the job
6/ Run koha qa test tools

Verify that the records without items have been deleted also.

NOTE: My test db only had two biblios with items, so I set
      MaxItemsForBatch=1.
      Before patch, checkbox did not display.
      After patch, checkbox did display.
      This patch merely moves one line out of the IF/ELSE/END
      block, and reindents for more readability. Though, there
      is a missing <p> if you want to get picky.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt