From a11d62975fb8e7d42b622d9ca25755d696bde7ae Mon Sep 17 00:00:00 2001
From: Aleisha Amohia <aleisha@catalyst.net.nz>
Date: Fri, 27 Sep 2024 14:57:48 +0000
Subject: [PATCH] Bug 38016: Rename booking circulation rules

This enhancement renames the bookings circulation rules to better describe what they do.

To test:

1. Go to Koha Administration -> Circulation and fines rules
2. Scroll to the 'Default holds and bookings policies by item type' section
3. Notice the bookings rules in this table:
  - Booking preparation period
  - Booking precaution period
4. Apply the patch and refresh the page
5. Confirm the bookings have been renamed to:
  - Booking pre-processing (days)
  - Booking post-processing (days)
6. Confirm these names make sense and it is clear what the rules are used for and how they are applied
7. Put values in the input fields for these rules and confirm saving a rule works as expected

Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index 370bd7b17a..0b143b0cea 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ -633,8 +633,8 @@
                                 <th>Maximum total holds allowed (count)</th>
                                 <th>Hold policy</th>
                                 <th>Hold pickup library match</th>
-                                <th>Booking preparation period</th>
-                                <th>Booking precaution period</th>
+                                <th>Booking pre-processing (days)</th>
+                                <th>Booking post-processing (days)</th>
                                 <th>Return policy</th>
                                 <th class="noExport">Actions</th>
                             </tr>
@@ -1317,8 +1317,8 @@
                                 <th>Item type</th>
                                 <th>Hold policy</th>
                                 <th>Hold pickup library match</th>
-                                <th>Booking preparation period</th>
-                                <th>Booking precaution period</th>
+                                <th>Booking pre-processing (days)</th>
+                                <th>Booking post-processing (days)</th>
                                 <th>Return policy</th>
                                 <th>&nbsp;</th>
                             </tr>
-- 
2.39.5